[GitHub] piiswrong commented on a change in pull request #10666: [MXNET-359] fix checks on convolution parameters in MKLDNN.

[GitBox <gi...@apache.org>]

piiswrong commented on a change in pull request #10666: [MXNET-359] fix checks on convolution parameters in MKLDNN.
URL: https://github.com/apache/incubator-mxnet/pull/10666#discussion_r185582075
 
 

 ##########
 File path: src/operator/nn/convolution.cc
 ##########
 @@ -363,6 +365,9 @@ static void ConvolutionParamParser(nnvm::NodeAttrs* attrs) {
     if (param_.dilate.ndim() == 0) param_.dilate = Shape3(1, 1, 1);
     if (param_.pad.ndim() == 0) param_.pad = Shape3(0, 0, 0);
   }
+  CHECK_EQ(param_.kernel.ndim(), param_.stride.ndim());
 
 Review comment:
   These checks needs to have error messages.
   "stride must have the same number of dimensions with kernel_size, but kernel_size is set to (x,x,x) while stride is (x,x)"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services