You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/14 08:50:18 UTC
[GitHub] [hbase] HorizonNet opened a new pull request #1034: HBASE-23622
Reduced the number of Checkstyle violations in hbase-common
HorizonNet opened a new pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
URL: https://github.com/apache/hbase/pull/1034
Backport of #968 to branch-1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1034:
HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
URL: https://github.com/apache/hbase/pull/1034#discussion_r366483222
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
##########
@@ -557,71 +508,45 @@ static void setStoragePolicy(final FileSystem fs, final Path path, final String
*/
private static void invokeSetStoragePolicy(final FileSystem fs, final Path path,
final String storagePolicy) throws IOException {
- Method m = null;
Exception toThrow = null;
+
try {
- m = fs.getClass().getDeclaredMethod("setStoragePolicy",
- new Class<?>[] { Path.class, String.class });
- m.setAccessible(true);
- } catch (NoSuchMethodException e) {
- toThrow = e;
- final String msg = "FileSystem doesn't support setStoragePolicy; HDFS-6584 not available";
- if (!warningMap.containsKey(fs)) {
- warningMap.put(fs, true);
- LOG.warn(msg, e);
- } else if (LOG.isDebugEnabled()) {
- LOG.debug(msg, e);
+ fs.setStoragePolicy(path, storagePolicy);
+
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Set storagePolicy=" + storagePolicy + " for path=" + path);
}
- m = null;
- } catch (SecurityException e) {
+ } catch (Exception e) {
toThrow = e;
- final String msg = "No access to setStoragePolicy on FileSystem; HDFS-6584 not available";
+ // This swallows FNFE, should we be throwing it? seems more likely to indicate dev
+ // misuse than a runtime problem with HDFS.
if (!warningMap.containsKey(fs)) {
warningMap.put(fs, true);
- LOG.warn(msg, e);
+ LOG.warn("Unable to set storagePolicy=" + storagePolicy + " for path=" + path, e);
} else if (LOG.isDebugEnabled()) {
- LOG.debug(msg, e);
+ LOG.debug("Unable to set storagePolicy=" + storagePolicy + " for path=" + path, e);
}
- m = null; // could happen on setAccessible()
- }
- if (m != null) {
- try {
- m.invoke(fs, path, storagePolicy);
- if (LOG.isDebugEnabled()) {
- LOG.debug("Set storagePolicy=" + storagePolicy + " for path=" + path);
- }
- } catch (Exception e) {
- toThrow = e;
- // This swallows FNFE, should we be throwing it? seems more likely to indicate dev
- // misuse than a runtime problem with HDFS.
- if (!warningMap.containsKey(fs)) {
- warningMap.put(fs, true);
- LOG.warn("Unable to set storagePolicy=" + storagePolicy + " for path=" + path, e);
- } else if (LOG.isDebugEnabled()) {
- LOG.debug("Unable to set storagePolicy=" + storagePolicy + " for path=" + path, e);
- }
- // check for lack of HDFS-7228
- if (e instanceof InvocationTargetException) {
- final Throwable exception = e.getCause();
- if (exception instanceof RemoteException &&
- HadoopIllegalArgumentException.class.getName().equals(
- ((RemoteException)exception).getClassName())) {
- if (LOG.isDebugEnabled()) {
- LOG.debug("Given storage policy, '" +storagePolicy +"', was rejected and probably " +
- "isn't a valid policy for the version of Hadoop you're running. I.e. if you're " +
- "trying to use SSD related policies then you're likely missing HDFS-7228. For " +
- "more information see the 'ArchivalStorage' docs for your Hadoop release.");
- }
+ // check for lack of HDFS-7228
+ if (e instanceof InvocationTargetException) {
Review comment:
Updated the changes to unwrap the `InvocationTargetException` check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet merged pull request #1034: HBASE-23622 Reduced
the number of Checkstyle violations in hbase-common
Posted by GitBox <gi...@apache.org>.
HorizonNet merged pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
URL: https://github.com/apache/hbase/pull/1034
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1034:
HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
URL: https://github.com/apache/hbase/pull/1034#discussion_r366398962
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
##########
@@ -560,8 +558,7 @@ private static void invokeSetStoragePolicy(final FileSystem fs, final Path path,
Method m = null;
Exception toThrow = null;
try {
- m = fs.getClass().getDeclaredMethod("setStoragePolicy",
- new Class<?>[] { Path.class, String.class });
+ m = fs.getClass().getDeclaredMethod("setStoragePolicy", Path.class, String.class);
Review comment:
branch-1's minimum hadoop version is 2.8.5, so for that branch we can remove this reflection as well. Note to potential further backporters: the method is not in Hadoop 2.7, we'll need this reflection in branch-1.4 and branch-1.3.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1034:
HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
URL: https://github.com/apache/hbase/pull/1034#discussion_r366396601
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
##########
@@ -192,7 +191,7 @@ public static short getDefaultReplication(final FileSystem fs, final Path path)
Method m = null;
Class<? extends FileSystem> cls = fs.getClass();
try {
- m = cls.getMethod("getDefaultReplication", new Class<?>[] { Path.class });
+ m = cls.getMethod("getDefaultReplication", Path.class);
Review comment:
The method `getDefaultReplication(Path)` has been a supported API in all the Hadoop versions we support for a very longs time. We should skip the reflection here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1034:
HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
URL: https://github.com/apache/hbase/pull/1034#discussion_r366443618
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
##########
@@ -157,7 +156,7 @@ public static long getDefaultBlockSize(final FileSystem fs, final Path path) thr
Method m = null;
Class<? extends FileSystem> cls = fs.getClass();
try {
- m = cls.getMethod("getDefaultBlockSize", new Class<?>[] { Path.class });
+ m = cls.getMethod("getDefaultBlockSize", Path.class);
Review comment:
Removed the reflection part.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1034:
HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
URL: https://github.com/apache/hbase/pull/1034#discussion_r366521658
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
##########
@@ -557,71 +508,44 @@ static void setStoragePolicy(final FileSystem fs, final Path path, final String
*/
private static void invokeSetStoragePolicy(final FileSystem fs, final Path path,
final String storagePolicy) throws IOException {
- Method m = null;
Exception toThrow = null;
+
try {
- m = fs.getClass().getDeclaredMethod("setStoragePolicy",
- new Class<?>[] { Path.class, String.class });
- m.setAccessible(true);
- } catch (NoSuchMethodException e) {
- toThrow = e;
- final String msg = "FileSystem doesn't support setStoragePolicy; HDFS-6584 not available";
- if (!warningMap.containsKey(fs)) {
- warningMap.put(fs, true);
- LOG.warn(msg, e);
- } else if (LOG.isDebugEnabled()) {
- LOG.debug(msg, e);
+ fs.setStoragePolicy(path, storagePolicy);
+
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Set storagePolicy=" + storagePolicy + " for path=" + path);
}
- m = null;
- } catch (SecurityException e) {
+ } catch (Exception e) {
toThrow = e;
- final String msg = "No access to setStoragePolicy on FileSystem; HDFS-6584 not available";
+ // This swallows FNFE, should we be throwing it? seems more likely to indicate dev
+ // misuse than a runtime problem with HDFS.
if (!warningMap.containsKey(fs)) {
warningMap.put(fs, true);
- LOG.warn(msg, e);
+ LOG.warn("Unable to set storagePolicy=" + storagePolicy + " for path=" + path, e);
} else if (LOG.isDebugEnabled()) {
- LOG.debug(msg, e);
+ LOG.debug("Unable to set storagePolicy=" + storagePolicy + " for path=" + path, e);
}
- m = null; // could happen on setAccessible()
- }
- if (m != null) {
- try {
- m.invoke(fs, path, storagePolicy);
+
+ // check for lack of HDFS-7228
+ final Throwable exception = e.getCause();
Review comment:
I don't think this is correct. wouldn't `e` be the RemoteException?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1034: HBASE-23622 Reduced
the number of Checkstyle violations in hbase-common
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
URL: https://github.com/apache/hbase/pull/1034#issuecomment-574363686
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 1m 21s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 29s | branch-1 passed |
| +1 :green_heart: | compile | 0m 30s | branch-1 passed with JDK v1.8.0_232 |
| +1 :green_heart: | compile | 0m 35s | branch-1 passed with JDK v1.7.0_242 |
| +1 :green_heart: | checkstyle | 6m 8s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 11s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 29s | branch-1 passed with JDK v1.8.0_232 |
| +1 :green_heart: | javadoc | 0m 35s | branch-1 passed with JDK v1.7.0_242 |
| +0 :ok: | spotbugs | 1m 8s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +0 :ok: | findbugs | 0m 24s | branch/hbase-checkstyle no findbugs output file (findbugsXml.xml) |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 8s | the patch passed |
| +1 :green_heart: | compile | 0m 27s | the patch passed with JDK v1.8.0_232 |
| +1 :green_heart: | javac | 0m 27s | the patch passed |
| +1 :green_heart: | compile | 0m 33s | the patch passed with JDK v1.7.0_242 |
| +1 :green_heart: | javac | 0m 33s | the patch passed |
| +1 :green_heart: | checkstyle | 5m 55s | root: The patch generated 0 new + 25 unchanged - 16 fixed = 25 total (was 41) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 1 ill-formed XML file(s). |
| +1 :green_heart: | shadedjars | 3m 11s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 16s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 25s | the patch passed with JDK v1.8.0_232 |
| +1 :green_heart: | javadoc | 0m 32s | the patch passed with JDK v1.7.0_242 |
| +0 :ok: | findbugs | 0m 13s | hbase-checkstyle has no data from findbugs |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 11s | hbase-checkstyle in the patch passed. |
| +1 :green_heart: | unit | 2m 36s | hbase-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. |
| | | 50m 23s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1034/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1034 |
| Optional Tests | dupname asflicense checkstyle javac javadoc unit xml spotbugs findbugs shadedjars hadoopcheck hbaseanti compile |
| uname | Linux 6820c854d6f2 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1034/out/precommit/personality/provided.sh |
| git revision | branch-1 / b5d0da7 |
| Default Java | 1.7.0_242 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242 |
| xml | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1034/4/artifact/out/xml.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1034/4/testReport/ |
| Max. process+thread count | 171 (vs. ulimit of 10000) |
| modules | C: hbase-checkstyle hbase-common U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1034/4/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1034:
HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
URL: https://github.com/apache/hbase/pull/1034#discussion_r366385646
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteRangeUtils.java
##########
@@ -33,12 +33,16 @@
*/
@InterfaceAudience.Public
@InterfaceStability.Evolving
-public class ByteRangeUtils {
+public final class ByteRangeUtils {
+ private ByteRangeUtils() {
Review comment:
This is a binary incompatible change and matters because ByteRangeUtils is IA.Public
ref JLS 13.4.12
https://docs.oracle.com/javase/specs/jls/se13/html/jls-13.html#jls-13.4.12
Because there were no constructors defined and this class is marked `public`, this class implicitly had a `public ByteRangeUtils()` constructor. So changing it to `private` here will break compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1034:
HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
URL: https://github.com/apache/hbase/pull/1034#discussion_r366444309
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
##########
@@ -560,8 +558,7 @@ private static void invokeSetStoragePolicy(final FileSystem fs, final Path path,
Method m = null;
Exception toThrow = null;
try {
- m = fs.getClass().getDeclaredMethod("setStoragePolicy",
- new Class<?>[] { Path.class, String.class });
+ m = fs.getClass().getDeclaredMethod("setStoragePolicy", Path.class, String.class);
Review comment:
Removed the reflection part. Will create additional backports for branch-1.4 and branch-1.3.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1034:
HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
URL: https://github.com/apache/hbase/pull/1034#discussion_r366464295
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
##########
@@ -557,71 +508,45 @@ static void setStoragePolicy(final FileSystem fs, final Path path, final String
*/
private static void invokeSetStoragePolicy(final FileSystem fs, final Path path,
final String storagePolicy) throws IOException {
- Method m = null;
Exception toThrow = null;
+
try {
- m = fs.getClass().getDeclaredMethod("setStoragePolicy",
- new Class<?>[] { Path.class, String.class });
- m.setAccessible(true);
- } catch (NoSuchMethodException e) {
- toThrow = e;
- final String msg = "FileSystem doesn't support setStoragePolicy; HDFS-6584 not available";
- if (!warningMap.containsKey(fs)) {
- warningMap.put(fs, true);
- LOG.warn(msg, e);
- } else if (LOG.isDebugEnabled()) {
- LOG.debug(msg, e);
+ fs.setStoragePolicy(path, storagePolicy);
+
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Set storagePolicy=" + storagePolicy + " for path=" + path);
}
- m = null;
- } catch (SecurityException e) {
+ } catch (Exception e) {
toThrow = e;
- final String msg = "No access to setStoragePolicy on FileSystem; HDFS-6584 not available";
+ // This swallows FNFE, should we be throwing it? seems more likely to indicate dev
+ // misuse than a runtime problem with HDFS.
if (!warningMap.containsKey(fs)) {
warningMap.put(fs, true);
- LOG.warn(msg, e);
+ LOG.warn("Unable to set storagePolicy=" + storagePolicy + " for path=" + path, e);
} else if (LOG.isDebugEnabled()) {
- LOG.debug(msg, e);
+ LOG.debug("Unable to set storagePolicy=" + storagePolicy + " for path=" + path, e);
}
- m = null; // could happen on setAccessible()
- }
- if (m != null) {
- try {
- m.invoke(fs, path, storagePolicy);
- if (LOG.isDebugEnabled()) {
- LOG.debug("Set storagePolicy=" + storagePolicy + " for path=" + path);
- }
- } catch (Exception e) {
- toThrow = e;
- // This swallows FNFE, should we be throwing it? seems more likely to indicate dev
- // misuse than a runtime problem with HDFS.
- if (!warningMap.containsKey(fs)) {
- warningMap.put(fs, true);
- LOG.warn("Unable to set storagePolicy=" + storagePolicy + " for path=" + path, e);
- } else if (LOG.isDebugEnabled()) {
- LOG.debug("Unable to set storagePolicy=" + storagePolicy + " for path=" + path, e);
- }
- // check for lack of HDFS-7228
- if (e instanceof InvocationTargetException) {
- final Throwable exception = e.getCause();
- if (exception instanceof RemoteException &&
- HadoopIllegalArgumentException.class.getName().equals(
- ((RemoteException)exception).getClassName())) {
- if (LOG.isDebugEnabled()) {
- LOG.debug("Given storage policy, '" +storagePolicy +"', was rejected and probably " +
- "isn't a valid policy for the version of Hadoop you're running. I.e. if you're " +
- "trying to use SSD related policies then you're likely missing HDFS-7228. For " +
- "more information see the 'ArchivalStorage' docs for your Hadoop release.");
- }
+ // check for lack of HDFS-7228
+ if (e instanceof InvocationTargetException) {
Review comment:
Now that we're not using reflection, this should be a direct check for `RemoteException` because it won't be wrapped in the reflection invocation exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1034:
HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
URL: https://github.com/apache/hbase/pull/1034#discussion_r366443420
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteRangeUtils.java
##########
@@ -33,12 +33,16 @@
*/
@InterfaceAudience.Public
@InterfaceStability.Evolving
-public class ByteRangeUtils {
+public final class ByteRangeUtils {
+ private ByteRangeUtils() {
Review comment:
Reverted this change and put it onto the suppressions list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1034:
HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
URL: https://github.com/apache/hbase/pull/1034#discussion_r366538415
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
##########
@@ -557,71 +508,44 @@ static void setStoragePolicy(final FileSystem fs, final Path path, final String
*/
private static void invokeSetStoragePolicy(final FileSystem fs, final Path path,
final String storagePolicy) throws IOException {
- Method m = null;
Exception toThrow = null;
+
try {
- m = fs.getClass().getDeclaredMethod("setStoragePolicy",
- new Class<?>[] { Path.class, String.class });
- m.setAccessible(true);
- } catch (NoSuchMethodException e) {
- toThrow = e;
- final String msg = "FileSystem doesn't support setStoragePolicy; HDFS-6584 not available";
- if (!warningMap.containsKey(fs)) {
- warningMap.put(fs, true);
- LOG.warn(msg, e);
- } else if (LOG.isDebugEnabled()) {
- LOG.debug(msg, e);
+ fs.setStoragePolicy(path, storagePolicy);
+
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Set storagePolicy=" + storagePolicy + " for path=" + path);
}
- m = null;
- } catch (SecurityException e) {
+ } catch (Exception e) {
toThrow = e;
- final String msg = "No access to setStoragePolicy on FileSystem; HDFS-6584 not available";
+ // This swallows FNFE, should we be throwing it? seems more likely to indicate dev
+ // misuse than a runtime problem with HDFS.
if (!warningMap.containsKey(fs)) {
warningMap.put(fs, true);
- LOG.warn(msg, e);
+ LOG.warn("Unable to set storagePolicy=" + storagePolicy + " for path=" + path, e);
} else if (LOG.isDebugEnabled()) {
- LOG.debug(msg, e);
+ LOG.debug("Unable to set storagePolicy=" + storagePolicy + " for path=" + path, e);
}
- m = null; // could happen on setAccessible()
- }
- if (m != null) {
- try {
- m.invoke(fs, path, storagePolicy);
+
+ // check for lack of HDFS-7228
+ final Throwable exception = e.getCause();
Review comment:
Yes, you're right. I removed the part of getting the cause.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1034:
HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
URL: https://github.com/apache/hbase/pull/1034#discussion_r366443242
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteRangeUtils.java
##########
@@ -33,12 +33,16 @@
*/
@InterfaceAudience.Public
@InterfaceStability.Evolving
-public class ByteRangeUtils {
+public final class ByteRangeUtils {
Review comment:
I reverted this change. As this one is already pushed to higher versions, let me also revert it there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on issue #1034: HBASE-23622 Reduced
the number of Checkstyle violations in hbase-common
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on issue #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
URL: https://github.com/apache/hbase/pull/1034#issuecomment-575128383
Problem in the build seems to be related to [HBASE-22732](https://issues.apache.org/jira/browse/HBASE-22732]).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1034:
HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
URL: https://github.com/apache/hbase/pull/1034#discussion_r366382230
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteRangeUtils.java
##########
@@ -33,12 +33,16 @@
*/
@InterfaceAudience.Public
@InterfaceStability.Evolving
-public class ByteRangeUtils {
+public final class ByteRangeUtils {
Review comment:
this is a binary incompatible change and matters because ByteRangeUtils is IA.Public
ref: JLS 13.4.2 "final classes"
https://docs.oracle.com/javase/specs/jls/se13/html/jls-13.html#jls-13.4.2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1034:
HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
URL: https://github.com/apache/hbase/pull/1034#discussion_r366396488
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
##########
@@ -157,7 +156,7 @@ public static long getDefaultBlockSize(final FileSystem fs, final Path path) thr
Method m = null;
Class<? extends FileSystem> cls = fs.getClass();
try {
- m = cls.getMethod("getDefaultBlockSize", new Class<?>[] { Path.class });
+ m = cls.getMethod("getDefaultBlockSize", Path.class);
Review comment:
The method `getDefaultBlockSize(Path)` has been a supported API in all the Hadoop versions we support for a very longs time. We should skip the reflection here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1034: HBASE-23622 Reduced
the number of Checkstyle violations in hbase-common
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
URL: https://github.com/apache/hbase/pull/1034#issuecomment-574313200
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 18s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 1m 22s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 53s | branch-1 passed |
| +1 :green_heart: | compile | 0m 27s | branch-1 passed with JDK v1.8.0_232 |
| +1 :green_heart: | compile | 0m 35s | branch-1 passed with JDK v1.7.0_242 |
| +1 :green_heart: | checkstyle | 5m 27s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 49s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 32s | branch-1 passed with JDK v1.8.0_232 |
| +1 :green_heart: | javadoc | 0m 35s | branch-1 passed with JDK v1.7.0_242 |
| +0 :ok: | spotbugs | 1m 1s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +0 :ok: | findbugs | 0m 23s | branch/hbase-checkstyle no findbugs output file (findbugsXml.xml) |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 3s | the patch passed |
| +1 :green_heart: | compile | 0m 28s | the patch passed with JDK v1.8.0_232 |
| +1 :green_heart: | javac | 0m 28s | the patch passed |
| +1 :green_heart: | compile | 0m 36s | the patch passed with JDK v1.7.0_242 |
| +1 :green_heart: | javac | 0m 36s | the patch passed |
| +1 :green_heart: | checkstyle | 4m 56s | root: The patch generated 0 new + 25 unchanged - 16 fixed = 25 total (was 41) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 0s | The patch has 1 ill-formed XML file(s). |
| +1 :green_heart: | shadedjars | 2m 43s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 54s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 28s | the patch passed with JDK v1.8.0_232 |
| +1 :green_heart: | javadoc | 0m 35s | the patch passed with JDK v1.7.0_242 |
| +0 :ok: | findbugs | 0m 13s | hbase-checkstyle has no data from findbugs |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 13s | hbase-checkstyle in the patch passed. |
| +1 :green_heart: | unit | 2m 35s | hbase-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 23s | The patch does not generate ASF License warnings. |
| | | 47m 32s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1034/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1034 |
| Optional Tests | dupname asflicense checkstyle javac javadoc unit xml spotbugs findbugs shadedjars hadoopcheck hbaseanti compile |
| uname | Linux 74e10a56bffe 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1034/out/precommit/personality/provided.sh |
| git revision | branch-1 / b5d0da7 |
| Default Java | 1.7.0_242 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242 |
| xml | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1034/3/artifact/out/xml.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1034/3/testReport/ |
| Max. process+thread count | 181 (vs. ulimit of 10000) |
| modules | C: hbase-checkstyle hbase-common U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1034/3/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1034:
HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
URL: https://github.com/apache/hbase/pull/1034#discussion_r366443765
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
##########
@@ -192,7 +191,7 @@ public static short getDefaultReplication(final FileSystem fs, final Path path)
Method m = null;
Class<? extends FileSystem> cls = fs.getClass();
try {
- m = cls.getMethod("getDefaultReplication", new Class<?>[] { Path.class });
+ m = cls.getMethod("getDefaultReplication", Path.class);
Review comment:
Removed the reflection part.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1034: HBASE-23622 Reduced
the number of Checkstyle violations in hbase-common
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
URL: https://github.com/apache/hbase/pull/1034#issuecomment-574156111
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 28s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ branch-1 Compile Tests _ |
| +1 :green_heart: | mvninstall | 8m 35s | branch-1 passed |
| +1 :green_heart: | compile | 0m 19s | branch-1 passed with JDK v1.8.0_232 |
| +1 :green_heart: | compile | 0m 22s | branch-1 passed with JDK v1.7.0_242 |
| +1 :green_heart: | checkstyle | 0m 32s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 54s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 25s | branch-1 passed with JDK v1.8.0_232 |
| +1 :green_heart: | javadoc | 0m 24s | branch-1 passed with JDK v1.7.0_242 |
| +0 :ok: | spotbugs | 1m 17s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 1m 14s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 5s | the patch passed |
| +1 :green_heart: | compile | 0m 18s | the patch passed with JDK v1.8.0_232 |
| +1 :green_heart: | javac | 0m 18s | the patch passed |
| +1 :green_heart: | compile | 0m 22s | the patch passed with JDK v1.7.0_242 |
| +1 :green_heart: | javac | 0m 22s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 28s | hbase-common: The patch generated 0 new + 27 unchanged - 14 fixed = 27 total (was 41) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 2m 52s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 11s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 18s | the patch passed with JDK v1.8.0_232 |
| +1 :green_heart: | javadoc | 0m 23s | the patch passed with JDK v1.7.0_242 |
| +1 :green_heart: | findbugs | 1m 11s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 34s | hbase-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. |
| | | 36m 0s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1034/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1034 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux fe95c7662d0f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1034/out/precommit/personality/provided.sh |
| git revision | branch-1 / b5d0da7 |
| Default Java | 1.7.0_242 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1034/1/testReport/ |
| Max. process+thread count | 178 (vs. ulimit of 10000) |
| modules | C: hbase-common U: hbase-common |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1034/1/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1034: HBASE-23622 Reduced
the number of Checkstyle violations in hbase-common
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
URL: https://github.com/apache/hbase/pull/1034#issuecomment-574287986
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 7m 11s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 1m 44s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 55s | branch-1 passed |
| +1 :green_heart: | compile | 0m 30s | branch-1 passed with JDK v1.8.0_232 |
| +1 :green_heart: | compile | 0m 35s | branch-1 passed with JDK v1.7.0_242 |
| +1 :green_heart: | checkstyle | 5m 0s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 53s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 32s | branch-1 passed with JDK v1.8.0_232 |
| +1 :green_heart: | javadoc | 0m 35s | branch-1 passed with JDK v1.7.0_242 |
| +0 :ok: | spotbugs | 1m 3s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +0 :ok: | findbugs | 0m 25s | branch/hbase-checkstyle no findbugs output file (findbugsXml.xml) |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 59s | the patch passed |
| +1 :green_heart: | compile | 0m 28s | the patch passed with JDK v1.8.0_232 |
| +1 :green_heart: | javac | 0m 28s | the patch passed |
| +1 :green_heart: | compile | 0m 34s | the patch passed with JDK v1.7.0_242 |
| +1 :green_heart: | javac | 0m 34s | the patch passed |
| +1 :green_heart: | checkstyle | 5m 27s | root: The patch generated 0 new + 25 unchanged - 16 fixed = 25 total (was 41) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | xml | 0m 1s | The patch has 1 ill-formed XML file(s). |
| +1 :green_heart: | shadedjars | 2m 42s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 58s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 28s | the patch passed with JDK v1.8.0_232 |
| +1 :green_heart: | javadoc | 0m 36s | the patch passed with JDK v1.7.0_242 |
| +0 :ok: | findbugs | 0m 14s | hbase-checkstyle has no data from findbugs |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 13s | hbase-checkstyle in the patch passed. |
| +1 :green_heart: | unit | 2m 33s | hbase-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 23s | The patch does not generate ASF License warnings. |
| | | 54m 15s | |
| Reason | Tests |
|-------:|:------|
| XML | Parsing Error(s): |
| | hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1034/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1034 |
| Optional Tests | dupname asflicense checkstyle javac javadoc unit xml spotbugs findbugs shadedjars hadoopcheck hbaseanti compile |
| uname | Linux cffb61f88762 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1034/out/precommit/personality/provided.sh |
| git revision | branch-1 / b5d0da7 |
| Default Java | 1.7.0_242 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242 |
| xml | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1034/2/artifact/out/xml.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1034/2/testReport/ |
| Max. process+thread count | 162 (vs. ulimit of 10000) |
| modules | C: hbase-checkstyle hbase-common U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1034/2/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services