[GitHub] [hive] belugabehr commented on a change in pull request #1313: HIVE-23829: Compute Stats Incorrect for Binary Columns

[GitBox <gi...@apache.org>]

belugabehr commented on a change in pull request #1313:
URL: https://github.com/apache/hive/pull/1313#discussion_r461115069



##########
File path: serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySerDeParameters.java
##########
@@ -53,7 +53,9 @@
   	= "hive.serialization.extend.nesting.levels";
   public static final String SERIALIZATION_EXTEND_ADDITIONAL_NESTING_LEVELS
 	= "hive.serialization.extend.additional.nesting.levels";
-
+  public static final String SERIALIZATION_DECODE_BINARY_AS_BASE64
+  	= "hive.serialization.decode.binary.as.base.64";

Review comment:
       Just make this `base64` (one word)

##########
File path: serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySerDeParameters.java
##########
@@ -116,7 +121,7 @@ public LazySerDeParameters(Configuration job, Properties tbl, String serdeName)
 
     extendedBooleanLiteral = (job == null ? false :
         job.getBoolean(ConfVars.HIVE_LAZYSIMPLE_EXTENDED_BOOLEAN_LITERAL.varname, false));
-    
+

Review comment:
       Remove empty space change




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org