You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/23 14:38:21 UTC
[GitHub] [shardingsphere] strongduanmu opened a new pull request #7009: fix SQL Server pagination rewrite result
strongduanmu opened a new pull request #7009:
URL: https://github.com/apache/shardingsphere/pull/7009
Fixes #4867 .
Changes proposed in this pull request:
- fix SQL Server pagination rewrite result
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls edited a comment on pull request #7009: fix SQL Server pagination rewrite result
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #7009:
URL: https://github.com/apache/shardingsphere/pull/7009#issuecomment-678792233
## Pull Request Test Coverage Report for [Build 14043](https://coveralls.io/builds/32944023)
* **7** of **8** **(87.5%)** changed or added relevant lines in **1** file are covered.
* **27** unchanged lines in **4** files lost coverage.
* Overall coverage decreased (**-0.002%**) to **35.192%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/segment/select/pagination/engine/PaginationContextEngine.java](https://coveralls.io/builds/32944023/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fsegment%2Fselect%2Fpagination%2Fengine%2FPaginationContextEngine.java#L74) | 7 | 8 | 87.5%
<!-- | **Total:** | **7** | **8** | **87.5%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-core/src/main/java/org/apache/shardingsphere/proxy/frontend/executor/UserExecutorGroup.java](https://coveralls.io/builds/32944023/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-frontend%2Fshardingsphere-proxy-frontend-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Ffrontend%2Fexecutor%2FUserExecutorGroup.java#L60) | 1 | 77.78% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/segment/select/pagination/engine/PaginationContextEngine.java](https://coveralls.io/builds/32944023/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fsegment%2Fselect%2Fpagination%2Fengine%2FPaginationContextEngine.java#L75) | 1 | 90.91% |
| [shardingsphere-proxy/shardingsphere-proxy-orchestration/src/main/java/org/apache/shardingsphere/proxy/orchestration/schema/ProxyOrchestrationSchemaContexts.java](https://coveralls.io/builds/32944023/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Forchestration%2Fschema%2FProxyOrchestrationSchemaContexts.java#L50) | 5 | 10.34% |
| [shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-core/src/main/java/org/apache/shardingsphere/proxy/frontend/netty/FrontendChannelInboundHandler.java](https://coveralls.io/builds/32944023/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-frontend%2Fshardingsphere-proxy-frontend-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Ffrontend%2Fnetty%2FFrontendChannelInboundHandler.java#L42) | 20 | 0% |
<!-- | **Total:** | **27** | | -->
| Totals | [](https://coveralls.io/builds/32944023) |
| :-- | --: |
| Change from base [Build 14036](https://coveralls.io/builds/32938283): | -0.002% |
| Covered Lines: | 35357 |
| Relevant Lines: | 100468 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #7009: fix SQL Server pagination rewrite result
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7009:
URL: https://github.com/apache/shardingsphere/pull/7009#issuecomment-678792233
## Pull Request Test Coverage Report for [Build 14038](https://coveralls.io/builds/32939767)
* **3** of **8** **(37.5%)** changed or added relevant lines in **1** file are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.005%**) to **35.189%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/segment/select/pagination/engine/PaginationContextEngine.java](https://coveralls.io/builds/32939767/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fsegment%2Fselect%2Fpagination%2Fengine%2FPaginationContextEngine.java#L69) | 3 | 8 | 37.5%
<!-- | **Total:** | **3** | **8** | **37.5%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/segment/select/pagination/engine/PaginationContextEngine.java](https://coveralls.io/builds/32939767/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fsegment%2Fselect%2Fpagination%2Fengine%2FPaginationContextEngine.java#L55) | 3 | 63.64% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/32939767) |
| :-- | --: |
| Change from base [Build 14036](https://coveralls.io/builds/32938283): | -0.005% |
| Covered Lines: | 35352 |
| Relevant Lines: | 100462 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #7009: fix SQL Server pagination rewrite result
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #7009:
URL: https://github.com/apache/shardingsphere/pull/7009
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #7009: fix SQL Server pagination rewrite result
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #7009:
URL: https://github.com/apache/shardingsphere/pull/7009#issuecomment-678892899
@strongduanmu Hi Glad to see you improve the tests. I reviewed this PR and your unit test covered some key scenarios, I think. So merged it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org