You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/12 20:35:58 UTC
Review Request 67900: Fixed compilation error with `DispatchProcess`
code.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67900/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler, Joseph Wu, and Michael Park.
Bugs: MESOS-8686
https://issues.apache.org/jira/browse/MESOS-8686
Repository: mesos
Description
-------
Per MESOS-8686 and MESOS-8915, the benchmark test
`ProcessTest.Process_BENCHMARK_DispatchDefer` had been disabled as the
`DispatchProcess` class no longer compiled with `/permissive-` using
the latest version of MSVC. The fix is thanks to PhoebeHui.
Diffs
-----
3rdparty/libprocess/src/tests/benchmarks.cpp 604122a2f33d7abfab92631d9eac33b6753e846b
Diff: https://reviews.apache.org/r/67900/diff/1/
Testing
-------
On Windows:
```
> .\3rdparty\libprocess\src\tests\benchmarks.exe
[==========] Running 5 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 5 tests from ProcessTest
[ RUN ] ProcessTest.Process_BENCHMARK_ClientServer
Client 0: 102041 rpcs / sec
Client 1: 102041 rpcs / sec
Client 2: 100002 rpcs / sec
Client 3: 101012 rpcs / sec
Client 4: 100002 rpcs / sec
Client 5: 100002 rpcs / sec
Client 6: 101012 rpcs / sec
Client 7: 101012 rpcs / sec
Estimated Total: 761911 rpcs / sec
[ OK ] ProcessTest.Process_BENCHMARK_ClientServer (122 ms)
[ RUN ] ProcessTest.Process_BENCHMARK_LargeNumberOfLinks
Elapsed: 88023us
[ OK ] ProcessTest.Process_BENCHMARK_LargeNumberOfLinks (291 ms)
[ RUN ] ProcessTest.Process_BENCHMARK_ThroughputPerformance
Estimated Total: 6399307.850863
[ OK ] ProcessTest.Process_BENCHMARK_ThroughputPerformance (2347 ms)
[ RUN ] ProcessTest.Process_BENCHMARK_DispatchDefer
Movable elapsed: 768.006300000000010ms
Copyable elapsed: 1.310028600000000secs
[ OK ] ProcessTest.Process_BENCHMARK_DispatchDefer (2082 ms)
[ RUN ] ProcessTest.Process_BENCHMARK_ProtobufInstallHandler
Size: 4 bytes, throughput: 3445844 messages/s
Size: 10 bytes, throughput: 2384994 messages/s
Size: 34 bytes, throughput: 1347373 messages/s
Size: 64 bytes, throughput: 990755 messages/s
Size: 304 bytes, throughput: 328788 messages/s
Size: 605 bytes, throughput: 181178 messages/s
Size: 3011 bytes, throughput: 39931 messages/s
Size: 6019 bytes, throughput: 20242 messages/s
Size: 30081 bytes, throughput: 4039 messages/s
Size: 60160 bytes, throughput: 1952 messages/s
[ OK ] ProcessTest.Process_BENCHMARK_ProtobufInstallHandler (10028 ms)
[----------] 5 tests from ProcessTest (14873 ms total)
[----------] Global test environment tear-down
[==========] 5 tests from 1 test case ran. (14874 ms total)
[ PASSED ] 5 tests.
```
Thanks,
Andrew Schwartzmeyer
Re: Review Request 67900: Fixed compilation error with
`DispatchProcess` code.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67900/#review206031
-----------------------------------------------------------
PASS: Mesos patch 67900 was successfully built and tested.
Reviews applied: `['67900']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1913/mesos-review-67900
- Mesos Reviewbot Windows
On July 12, 2018, 8:35 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67900/
> -----------------------------------------------------------
>
> (Updated July 12, 2018, 8:35 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-8686
> https://issues.apache.org/jira/browse/MESOS-8686
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Per MESOS-8686 and MESOS-8915, the benchmark test
> `ProcessTest.Process_BENCHMARK_DispatchDefer` had been disabled as the
> `DispatchProcess` class no longer compiled with `/permissive-` using
> the latest version of MSVC. The fix is thanks to PhoebeHui.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/benchmarks.cpp 604122a2f33d7abfab92631d9eac33b6753e846b
>
>
> Diff: https://reviews.apache.org/r/67900/diff/1/
>
>
> Testing
> -------
>
> On Windows:
>
> ```
> > .\3rdparty\libprocess\src\tests\benchmarks.exe
> [==========] Running 5 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 5 tests from ProcessTest
> [ RUN ] ProcessTest.Process_BENCHMARK_ClientServer
> Client 0: 117669 rpcs / sec
> Client 1: 116301 rpcs / sec
> Client 2: 116301 rpcs / sec
> Client 3: 117649 rpcs / sec
> Client 4: 116280 rpcs / sec
> Client 5: 116280 rpcs / sec
> Client 6: 117648 rpcs / sec
> Client 7: 117648 rpcs / sec
> Estimated Total: 888900 rpcs / sec
> [ OK ] ProcessTest.Process_BENCHMARK_ClientServer (107 ms)
> [ RUN ] ProcessTest.Process_BENCHMARK_LargeNumberOfLinks
> Elapsed: 80.0271ms
> [ OK ] ProcessTest.Process_BENCHMARK_LargeNumberOfLinks (273 ms)
> [ RUN ] ProcessTest.Process_BENCHMARK_ThroughputPerformance
> Estimated Total: 6714374.836421
> [ OK ] ProcessTest.Process_BENCHMARK_ThroughputPerformance (2235 ms)
> [ RUN ] ProcessTest.Process_BENCHMARK_DispatchDefer
> Movable elapsed: 847.036100000000033ms
> Copyable elapsed: 1.337995300000000secs
> [ OK ] ProcessTest.Process_BENCHMARK_DispatchDefer (2189 ms)
> [ RUN ] ProcessTest.Process_BENCHMARK_ProtobufInstallHandler
> Size: 4 bytes, throughput: 3388581 messages/s
> Size: 10 bytes, throughput: 2395662 messages/s
> Size: 34 bytes, throughput: 1343124 messages/s
> Size: 64 bytes, throughput: 1000243 messages/s
> Size: 304 bytes, throughput: 329189 messages/s
> Size: 605 bytes, throughput: 178676 messages/s
> Size: 3011 bytes, throughput: 40253 messages/s
> Size: 6019 bytes, throughput: 19969 messages/s
> Size: 30081 bytes, throughput: 4015 messages/s
> Size: 60160 bytes, throughput: 1993 messages/s
> [ OK ] ProcessTest.Process_BENCHMARK_ProtobufInstallHandler (10027 ms)
> [----------] 5 tests from ProcessTest (14833 ms total)
>
> [----------] Global test environment tear-down
> [==========] 5 tests from 1 test case ran. (14837 ms total)
> [ PASSED ] 5 tests.
> ```
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 67900: Fixed compilation error with
`DispatchProcess` code.
Posted by Benjamin Mahler <bm...@apache.org>.
Thanks for clarifying!
On Thu, Jul 12, 2018 at 4:40 PM Andrew Schwartzmeyer <
andrew@schwartzmeyer.com> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67900/
>
> On July 12th, 2018, 3:39 p.m. PDT, *Benjamin Mahler* wrote:
>
> Could we clarify that it's windows specific in the summary and that we're re-enabling the benchmark? E.g.
>
> "Re-enabled <xxxTest> on windows."
>
> This patch in its entirety though is not Windows specific. The change (adding this->) is on all platforms. Re-enabling the test is Windows-specific.
>
>
> - Andrew
>
> On July 12th, 2018, 1:35 p.m. PDT, Andrew Schwartzmeyer wrote:
> Review request for mesos, Benjamin Mahler, Joseph Wu, and Michael Park.
> By Andrew Schwartzmeyer.
>
> *Updated July 12, 2018, 1:35 p.m.*
> *Bugs: * MESOS-8686 <https://issues.apache.org/jira/browse/MESOS-8686>
> *Repository: * mesos
> Description
>
> Per MESOS-8686 and MESOS-8915, the benchmark testProcessTest.Process_BENCHMARK_DispatchDefer had been disabled as theDispatchProcess class no longer compiled with /permissive- using
> the latest version of MSVC. The fix is thanks to PhoebeHui.
>
> Testing
>
> On Windows:
>
> > .\3rdparty\libprocess\src\tests\benchmarks.exe
> [==========] Running 5 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 5 tests from ProcessTest
> [ RUN ] ProcessTest.Process_BENCHMARK_ClientServer
> Client 0: 117669 rpcs / sec
> Client 1: 116301 rpcs / sec
> Client 2: 116301 rpcs / sec
> Client 3: 117649 rpcs / sec
> Client 4: 116280 rpcs / sec
> Client 5: 116280 rpcs / sec
> Client 6: 117648 rpcs / sec
> Client 7: 117648 rpcs / sec
> Estimated Total: 888900 rpcs / sec
> [ OK ] ProcessTest.Process_BENCHMARK_ClientServer (107 ms)
> [ RUN ] ProcessTest.Process_BENCHMARK_LargeNumberOfLinks
> Elapsed: 80.0271ms
> [ OK ] ProcessTest.Process_BENCHMARK_LargeNumberOfLinks (273 ms)
> [ RUN ] ProcessTest.Process_BENCHMARK_ThroughputPerformance
> Estimated Total: 6714374.836421
> [ OK ] ProcessTest.Process_BENCHMARK_ThroughputPerformance (2235 ms)
> [ RUN ] ProcessTest.Process_BENCHMARK_DispatchDefer
> Movable elapsed: 847.036100000000033ms
> Copyable elapsed: 1.337995300000000secs
> [ OK ] ProcessTest.Process_BENCHMARK_DispatchDefer (2189 ms)
> [ RUN ] ProcessTest.Process_BENCHMARK_ProtobufInstallHandler
> Size: 4 bytes, throughput: 3388581 messages/s
> Size: 10 bytes, throughput: 2395662 messages/s
> Size: 34 bytes, throughput: 1343124 messages/s
> Size: 64 bytes, throughput: 1000243 messages/s
> Size: 304 bytes, throughput: 329189 messages/s
> Size: 605 bytes, throughput: 178676 messages/s
> Size: 3011 bytes, throughput: 40253 messages/s
> Size: 6019 bytes, throughput: 19969 messages/s
> Size: 30081 bytes, throughput: 4015 messages/s
> Size: 60160 bytes, throughput: 1993 messages/s
> [ OK ] ProcessTest.Process_BENCHMARK_ProtobufInstallHandler (10027 ms)
> [----------] 5 tests from ProcessTest (14833 ms total)
>
> [----------] Global test environment tear-down
> [==========] 5 tests from 1 test case ran. (14837 ms total)
> [ PASSED ] 5 tests.
>
> Diffs
>
> - 3rdparty/libprocess/src/tests/benchmarks.cpp
> (604122a2f33d7abfab92631d9eac33b6753e846b)
>
> View Diff <https://reviews.apache.org/r/67900/diff/1/>
>
Re: Review Request 67900: Fixed compilation error with
`DispatchProcess` code.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On July 12, 2018, 3:39 p.m., Benjamin Mahler wrote:
> > Could we clarify that it's windows specific in the summary and that we're re-enabling the benchmark? E.g.
> >
> > "Re-enabled <xxxTest> on windows."
This patch in its entirety though is not Windows specific. The change (adding `this->`) is on all platforms. Re-enabling the test is Windows-specific.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67900/#review206032
-----------------------------------------------------------
On July 12, 2018, 1:35 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67900/
> -----------------------------------------------------------
>
> (Updated July 12, 2018, 1:35 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-8686
> https://issues.apache.org/jira/browse/MESOS-8686
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Per MESOS-8686 and MESOS-8915, the benchmark test
> `ProcessTest.Process_BENCHMARK_DispatchDefer` had been disabled as the
> `DispatchProcess` class no longer compiled with `/permissive-` using
> the latest version of MSVC. The fix is thanks to PhoebeHui.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/benchmarks.cpp 604122a2f33d7abfab92631d9eac33b6753e846b
>
>
> Diff: https://reviews.apache.org/r/67900/diff/1/
>
>
> Testing
> -------
>
> On Windows:
>
> ```
> > .\3rdparty\libprocess\src\tests\benchmarks.exe
> [==========] Running 5 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 5 tests from ProcessTest
> [ RUN ] ProcessTest.Process_BENCHMARK_ClientServer
> Client 0: 117669 rpcs / sec
> Client 1: 116301 rpcs / sec
> Client 2: 116301 rpcs / sec
> Client 3: 117649 rpcs / sec
> Client 4: 116280 rpcs / sec
> Client 5: 116280 rpcs / sec
> Client 6: 117648 rpcs / sec
> Client 7: 117648 rpcs / sec
> Estimated Total: 888900 rpcs / sec
> [ OK ] ProcessTest.Process_BENCHMARK_ClientServer (107 ms)
> [ RUN ] ProcessTest.Process_BENCHMARK_LargeNumberOfLinks
> Elapsed: 80.0271ms
> [ OK ] ProcessTest.Process_BENCHMARK_LargeNumberOfLinks (273 ms)
> [ RUN ] ProcessTest.Process_BENCHMARK_ThroughputPerformance
> Estimated Total: 6714374.836421
> [ OK ] ProcessTest.Process_BENCHMARK_ThroughputPerformance (2235 ms)
> [ RUN ] ProcessTest.Process_BENCHMARK_DispatchDefer
> Movable elapsed: 847.036100000000033ms
> Copyable elapsed: 1.337995300000000secs
> [ OK ] ProcessTest.Process_BENCHMARK_DispatchDefer (2189 ms)
> [ RUN ] ProcessTest.Process_BENCHMARK_ProtobufInstallHandler
> Size: 4 bytes, throughput: 3388581 messages/s
> Size: 10 bytes, throughput: 2395662 messages/s
> Size: 34 bytes, throughput: 1343124 messages/s
> Size: 64 bytes, throughput: 1000243 messages/s
> Size: 304 bytes, throughput: 329189 messages/s
> Size: 605 bytes, throughput: 178676 messages/s
> Size: 3011 bytes, throughput: 40253 messages/s
> Size: 6019 bytes, throughput: 19969 messages/s
> Size: 30081 bytes, throughput: 4015 messages/s
> Size: 60160 bytes, throughput: 1993 messages/s
> [ OK ] ProcessTest.Process_BENCHMARK_ProtobufInstallHandler (10027 ms)
> [----------] 5 tests from ProcessTest (14833 ms total)
>
> [----------] Global test environment tear-down
> [==========] 5 tests from 1 test case ran. (14837 ms total)
> [ PASSED ] 5 tests.
> ```
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 67900: Fixed compilation error with
`DispatchProcess` code.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67900/#review206032
-----------------------------------------------------------
Fix it, then Ship it!
Could we clarify that it's windows specific in the summary and that we're re-enabling the benchmark? E.g.
"Re-enabled <xxxTest> on windows."
3rdparty/libprocess/src/tests/benchmarks.cpp
Line 529 (original), 527 (patched)
<https://reviews.apache.org/r/67900/#comment288989>
Does this warrant a comment?
- Benjamin Mahler
On July 12, 2018, 8:35 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67900/
> -----------------------------------------------------------
>
> (Updated July 12, 2018, 8:35 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-8686
> https://issues.apache.org/jira/browse/MESOS-8686
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Per MESOS-8686 and MESOS-8915, the benchmark test
> `ProcessTest.Process_BENCHMARK_DispatchDefer` had been disabled as the
> `DispatchProcess` class no longer compiled with `/permissive-` using
> the latest version of MSVC. The fix is thanks to PhoebeHui.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/benchmarks.cpp 604122a2f33d7abfab92631d9eac33b6753e846b
>
>
> Diff: https://reviews.apache.org/r/67900/diff/1/
>
>
> Testing
> -------
>
> On Windows:
>
> ```
> > .\3rdparty\libprocess\src\tests\benchmarks.exe
> [==========] Running 5 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 5 tests from ProcessTest
> [ RUN ] ProcessTest.Process_BENCHMARK_ClientServer
> Client 0: 117669 rpcs / sec
> Client 1: 116301 rpcs / sec
> Client 2: 116301 rpcs / sec
> Client 3: 117649 rpcs / sec
> Client 4: 116280 rpcs / sec
> Client 5: 116280 rpcs / sec
> Client 6: 117648 rpcs / sec
> Client 7: 117648 rpcs / sec
> Estimated Total: 888900 rpcs / sec
> [ OK ] ProcessTest.Process_BENCHMARK_ClientServer (107 ms)
> [ RUN ] ProcessTest.Process_BENCHMARK_LargeNumberOfLinks
> Elapsed: 80.0271ms
> [ OK ] ProcessTest.Process_BENCHMARK_LargeNumberOfLinks (273 ms)
> [ RUN ] ProcessTest.Process_BENCHMARK_ThroughputPerformance
> Estimated Total: 6714374.836421
> [ OK ] ProcessTest.Process_BENCHMARK_ThroughputPerformance (2235 ms)
> [ RUN ] ProcessTest.Process_BENCHMARK_DispatchDefer
> Movable elapsed: 847.036100000000033ms
> Copyable elapsed: 1.337995300000000secs
> [ OK ] ProcessTest.Process_BENCHMARK_DispatchDefer (2189 ms)
> [ RUN ] ProcessTest.Process_BENCHMARK_ProtobufInstallHandler
> Size: 4 bytes, throughput: 3388581 messages/s
> Size: 10 bytes, throughput: 2395662 messages/s
> Size: 34 bytes, throughput: 1343124 messages/s
> Size: 64 bytes, throughput: 1000243 messages/s
> Size: 304 bytes, throughput: 329189 messages/s
> Size: 605 bytes, throughput: 178676 messages/s
> Size: 3011 bytes, throughput: 40253 messages/s
> Size: 6019 bytes, throughput: 19969 messages/s
> Size: 30081 bytes, throughput: 4015 messages/s
> Size: 60160 bytes, throughput: 1993 messages/s
> [ OK ] ProcessTest.Process_BENCHMARK_ProtobufInstallHandler (10027 ms)
> [----------] 5 tests from ProcessTest (14833 ms total)
>
> [----------] Global test environment tear-down
> [==========] 5 tests from 1 test case ran. (14837 ms total)
> [ PASSED ] 5 tests.
> ```
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 67900: Fixed compilation error with
`DispatchProcess` code.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67900/
-----------------------------------------------------------
(Updated July 12, 2018, 4:44 p.m.)
Review request for mesos, Benjamin Mahler, Joseph Wu, and Michael Park.
Changes
-------
Added comment and clarified commit message.
Bugs: MESOS-8686
https://issues.apache.org/jira/browse/MESOS-8686
Repository: mesos
Description (updated)
-------
Per MESOS-8686 and MESOS-8915, the benchmark test
`ProcessTest.Process_BENCHMARK_DispatchDefer` had been disabled on
Windows as the `DispatchProcess` class no longer compiled with
`/permissive-` using the latest version of MSVC. The fix is thanks to
PhoebeHui.
Diffs (updated)
-----
3rdparty/libprocess/src/tests/benchmarks.cpp 604122a2f33d7abfab92631d9eac33b6753e846b
Diff: https://reviews.apache.org/r/67900/diff/2/
Changes: https://reviews.apache.org/r/67900/diff/1-2/
Testing
-------
On Windows:
```
> .\3rdparty\libprocess\src\tests\benchmarks.exe
[==========] Running 5 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 5 tests from ProcessTest
[ RUN ] ProcessTest.Process_BENCHMARK_ClientServer
Client 0: 117669 rpcs / sec
Client 1: 116301 rpcs / sec
Client 2: 116301 rpcs / sec
Client 3: 117649 rpcs / sec
Client 4: 116280 rpcs / sec
Client 5: 116280 rpcs / sec
Client 6: 117648 rpcs / sec
Client 7: 117648 rpcs / sec
Estimated Total: 888900 rpcs / sec
[ OK ] ProcessTest.Process_BENCHMARK_ClientServer (107 ms)
[ RUN ] ProcessTest.Process_BENCHMARK_LargeNumberOfLinks
Elapsed: 80.0271ms
[ OK ] ProcessTest.Process_BENCHMARK_LargeNumberOfLinks (273 ms)
[ RUN ] ProcessTest.Process_BENCHMARK_ThroughputPerformance
Estimated Total: 6714374.836421
[ OK ] ProcessTest.Process_BENCHMARK_ThroughputPerformance (2235 ms)
[ RUN ] ProcessTest.Process_BENCHMARK_DispatchDefer
Movable elapsed: 847.036100000000033ms
Copyable elapsed: 1.337995300000000secs
[ OK ] ProcessTest.Process_BENCHMARK_DispatchDefer (2189 ms)
[ RUN ] ProcessTest.Process_BENCHMARK_ProtobufInstallHandler
Size: 4 bytes, throughput: 3388581 messages/s
Size: 10 bytes, throughput: 2395662 messages/s
Size: 34 bytes, throughput: 1343124 messages/s
Size: 64 bytes, throughput: 1000243 messages/s
Size: 304 bytes, throughput: 329189 messages/s
Size: 605 bytes, throughput: 178676 messages/s
Size: 3011 bytes, throughput: 40253 messages/s
Size: 6019 bytes, throughput: 19969 messages/s
Size: 30081 bytes, throughput: 4015 messages/s
Size: 60160 bytes, throughput: 1993 messages/s
[ OK ] ProcessTest.Process_BENCHMARK_ProtobufInstallHandler (10027 ms)
[----------] 5 tests from ProcessTest (14833 ms total)
[----------] Global test environment tear-down
[==========] 5 tests from 1 test case ran. (14837 ms total)
[ PASSED ] 5 tests.
```
Thanks,
Andrew Schwartzmeyer