You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "giuliotal (via GitHub)" <gi...@apache.org> on 2023/08/20 20:13:00 UTC
[GitHub] [superset] giuliotal opened a new pull request, #25034: docs: fix line break in Apache Druid page
giuliotal opened a new pull request, #25034:
URL: https://github.com/apache/superset/pull/25034
### SUMMARY
Added line breaks and highlighted using code formatting each keyword of the connection string
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
### ADDITIONAL INFORMATION
Fixes #25033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] giuliotal commented on pull request #25034: docs: fix line break in Apache Druid page
Posted by "giuliotal (via GitHub)" <gi...@apache.org>.
giuliotal commented on PR #25034:
URL: https://github.com/apache/superset/pull/25034#issuecomment-1685717729
@mdeshmu replaced line breaks (which required trailing white spaces) with a bullet list
The alternative is to use raw HTML, preferred a bullet list for clarity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sfirke merged pull request #25034: docs: fix line break in Apache Druid page
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke merged PR #25034:
URL: https://github.com/apache/superset/pull/25034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mdeshmu commented on pull request #25034: docs: fix line break in Apache Druid page
Posted by "mdeshmu (via GitHub)" <gi...@apache.org>.
mdeshmu commented on PR #25034:
URL: https://github.com/apache/superset/pull/25034#issuecomment-1685478917
ping @sfirke !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sfirke commented on pull request #25034: docs: fix line break in Apache Druid page
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #25034:
URL: https://github.com/apache/superset/pull/25034#issuecomment-1685489267
Agreed with @mdeshmu. While you are at it, could you also add "the" so it reads "in favor of the" in that first sentence?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org