You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/10/25 00:51:24 UTC

[GitHub] [incubator-tvm] masahi opened a new pull request #6752: [MKL] Fix offloading of batch_matmul to MKL

masahi opened a new pull request #6752:
URL: https://github.com/apache/incubator-tvm/pull/6752


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] masahi commented on pull request #6752: [MKL] Fix offloading of batch_matmul to MKL

Posted by GitBox <gi...@apache.org>.

masahi commented on pull request #6752:
URL: https://github.com/apache/incubator-tvm/pull/6752#issuecomment-716109981


   Thanks @comaniac 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6752: [MKL] Fix offloading of batch_matmul to MKL

Posted by GitBox <gi...@apache.org>.

comaniac commented on a change in pull request #6752:
URL: https://github.com/apache/incubator-tvm/pull/6752#discussion_r511541274



##########
File path: python/tvm/topi/x86/batch_matmul.py
##########
@@ -137,10 +137,9 @@ def _default_batch_matmul_config(cfg, M, N, K):
     cfg["tile_y"] = SplitEntity([M // y_bn, y_bn])
 
 
-@autotvm.register_topi_compute("batch_matmul_cblas.x86")
-def batch_matmul_cblas(cfg, x, y, out_shape=None):
+def batch_matmul_blas_common(cfg, x, y, out_shape, lib):

Review comment:
       Add `lib` to the docstring.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] masahi merged pull request #6752: [MKL] Fix offloading of batch_matmul to MKL

Posted by GitBox <gi...@apache.org>.

masahi merged pull request #6752:
URL: https://github.com/apache/incubator-tvm/pull/6752


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org