You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/06/10 08:08:19 UTC

[GitHub] [hudi] luoyajun526 commented on pull request #1720: [HUDI-1003] Handle partitions correctly for syncing hudi non-parititioned table to hive

luoyajun526 commented on pull request #1720:
URL: https://github.com/apache/hudi/pull/1720#issuecomment-641818863


   > ## _Tips_
   > * _Thank you very much for contributing to Apache Hudi._
   > * _Please review https://hudi.apache.org/contributing.html before opening a pull request._
   > 
   > ## What is the purpose of the pull request
   > This PR aims to create the table normally without partitions, when sync hudi non-parititioned table to hive.
   > JIRA: https://issues.apache.org/jira/browse/HUDI-1003
   > 
   > ## Brief change log
   > * Judge whether to reset partitionFields to empty or not according to HIVE_PARTITION_EXTRACTOR_CLASS_OPT_KEY, during building HiveSyncConfig.
   > 
   > ## Verify this pull request
   > _(Please pick either of the following options)_
   > 
   > This pull request is a trivial rework / code cleanup without any test coverage.
   > 
   > _(or)_
   > 
   > This pull request is already covered by existing tests, such as _(please describe tests)_.
   > 
   > (or)
   > 
   > This change added tests and can be verified as follows:
   > 
   > _(example:)_
   > 
   > * _Added integration tests for end-to-end._
   > * _Added HoodieClientWriteTest to verify the change._
   > * _Manually verified the change by running a job locally._
   > 
   > ## Committer checklist
   > * [ ]  Has a corresponding JIRA in PR title & commit
   > * [ ]  Commit message is descriptive of the change
   > * [ ]  CI is green
   > * [ ]  Necessary doc changes done or have another open PR
   > * [ ]  For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org