[GitHub] [griffin] dershovGD commented on a change in pull request #486: GRIFFIN-237 Implement service method get JobInstanceBean by id

[GitBox <gi...@apache.org>]

dershovGD commented on a change in pull request #486: GRIFFIN-237 Implement service method get JobInstanceBean by id
URL: https://github.com/apache/griffin/pull/486#discussion_r264186555
 
 

 ##########
 File path: service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java
 ##########
 @@ -288,6 +288,11 @@ public void deleteJob(String name) throws SchedulerException {
         return updateState(instances);
     }
 
+    @Override
+    public JobInstanceBean findInstance(Long id) {
+        return instanceRepo.findByInstanceId(id);
+    }
 
 Review comment:
   In case there is no bean with given id, I think, it would be better to throw an exception with explanation. We can log this information as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services