You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Francesco Mari (JIRA)" <ji...@apache.org> on 2017/01/17 11:52:26 UTC

[jira] [Commented] (OAK-5465) StandbyClientSyncExecution uses an unbound segment cache

    [ https://issues.apache.org/jira/browse/OAK-5465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15825930#comment-15825930 ] 

Francesco Mari commented on OAK-5465:
-------------------------------------

The segment cache used by {{StandbyClientSyncExecution}} is effectively useless. The segments loaded during the sync process are guaranteed not to be already present locally and processed only once. The cache is not providing any additional benefit and can be safely removed.

> StandbyClientSyncExecution uses an unbound segment cache
> --------------------------------------------------------
>
>                 Key: OAK-5465
>                 URL: https://issues.apache.org/jira/browse/OAK-5465
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segment-tar
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>            Priority: Blocker
>             Fix For: 1.5.18, 1.6
>
>
> {{StandbyClientSyncExecution}} uses a cache to avoid loading a {{Segment}} from the primary instance if it was already loaded before. This cache is simply an unbounded {{HashMap}}. In case a lot of segments are written on the primary instance (e.g. during compaction), this cache puts too much load on the standby instance - possibly resulting in out-of-memory errors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)