[PR] fix(web): name the shared instance selector [rocketmq-dashboard]

["zmuxuny (via GitHub)" <gi...@apache.org>]

zmuxuny opened a new pull request, #7163:
URL: https://github.com/apache/rocketmq-dashboard/pull/7163

   ### What does this PR do?
   
   Fixes #7162.
   
   Give the real searchable combobox in the shared `InstanceSelect` an accessible name using the same existing translated/caller-provided prompt as its visible placeholder. This shared selector appears in Message, Topic, DLQ, ACL and Consumer; none of those five call sites supplies an external label.
   
   The production change is one `aria-label` prop. Search, selection, clearing, error/retry rendering and the visible placeholder are unchanged. No new translation keys or dependency changes.
   
   ### Why is this change needed?
   
   Ant Design's visible placeholder and selected option do not name its search input. The control therefore has an empty accessible name even with an instance selected. The gap also affects an explicit caller prompt and the failed-instance-list UI.
   
   ### Tests
   
   - The exact same four new tests fail on unchanged production code (four existing component tests still pass).
   - With the fix, 19 tests in four files pass: the real `InstanceSelect` suite and existing language-context, translation and language-preference suites.
   - New cases verify selected-value Chinese/English names, an explicit caller prompt and the failed-list state through role/name queries against the real Ant Design control.
   - Forced TypeScript project build, changed-file ESLint and Prettier checks, and `git diff --check` pass.
   - This is focused React Testing Library/jsdom validation. No manual screen-reader, live-cluster, backend or full-frontend-suite run is claimed.
   
   ### Scope / related work
   
   #3235/#3062 and #3762 cover visible placeholder localization/tests, #2786/#2874 search normalization, and #6348 failed list loading. #7150 labels separate instance-inventory search/access-type controls; it does not modify this shared component. This PR fixes the common component once rather than splitting its five callers.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(web): consolidate accessible names and interaction coverage [rocketmq-dashboard]

["zmuxuny (via GitHub)" <gi...@apache.org>]

zmuxuny commented on PR #7163:
URL: https://github.com/apache/rocketmq-dashboard/pull/7163#issuecomment-6363179942

   CI follow-up: this PR and #7102, #7113, #7215, #7143, and #7114 now each carry the same five-line ConsumerPage test-isolation fix from 381c5c42 (previously validated in #6758, with credit to pilichoumao's #6521). The failing manual stack/subscription tests could race the real two-second background polling and consume mock responses. Only those two tests now fake setInterval/clearInterval, and real timers are restored after cleanup. Production polling, all existing assertions, and the independent real two-second auto-refresh test are unchanged. No business changes were combined across PRs.
   
   Validation: all six branches passed their focused suites, changed-file ESLint/Prettier, a forced TypeScript build, production build, and license checks. Focused results were 181 tests here, 146 in #7102, 381 in #7113, 85 in #7215, and 59 each in #7143/#7114. This PR additionally passed the complete frontend suite: 162 files / 1,845 tests. Backend Java/Go code was untouched and was not rerun locally. New hosted CI is queued, not yet green: https://github.com/apache/rocketmq-dashboard/actions/runs/39941472643 .
   
   AI assistance was used for diagnosis, patch verification, and validation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(web): consolidate accessible names and interaction coverage [rocketmq-dashboard]

["zmuxuny (via GitHub)" <gi...@apache.org>]

zmuxuny commented on PR #7163:
URL: https://github.com/apache/rocketmq-dashboard/pull/7163#issuecomment-6384075563

   @lizhimins Following up with the completed CI results: #7163, #7102, #7113, #7215, #7143 and #7114 now all have successful CI runs for their current heads. This PR's run is https://github.com/apache/rocketmq-dashboard/actions/runs/39941472643 . The shared ConsumerPage test-isolation fix described above is included; the six business changes remain separate.
   
   Could you review this batch and re-review #5251 and #5025, whose current-head CI also passes? Those two still show your earlier changes-requested reviews. Please flag any remaining review items, and consider merging the PRs that meet the project's requirements. If another maintainer should review part of the queue, a reviewer or preferred order would help. Keeping the request in one thread rather than pinging every PR. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org