You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Esteve Fernandez (JIRA)" <ji...@apache.org> on 2008/11/20 18:40:44 UTC
[jira] Created: (THRIFT-209) TTransportFactory can't be subclassed
properly
TTransportFactory can't be subclassed properly
----------------------------------------------
Key: THRIFT-209
URL: https://issues.apache.org/jira/browse/THRIFT-209
Project: Thrift
Issue Type: Bug
Components: Library (C#)
Reporter: Esteve Fernandez
The TTransportFactory.GetTransport method is not declared as virtual, preventing it from being overriden in subclasses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-209) TTransportFactory can't be
subclassed properly
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669267#action_12669267 ]
Esteve Fernandez commented on THRIFT-209:
-----------------------------------------
Please, could someone close this issue? It's two months old and I cannot think of any problem the patch could cause.
> TTransportFactory can't be subclassed properly
> ----------------------------------------------
>
> Key: THRIFT-209
> URL: https://issues.apache.org/jira/browse/THRIFT-209
> Project: Thrift
> Issue Type: Bug
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Attachments: thrift-209.patch
>
>
> The TTransportFactory.GetTransport method is not declared as virtual, preventing it from being overriden in subclasses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-209) TTransportFactory can't be subclassed
properly
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Esteve Fernandez updated THRIFT-209:
------------------------------------
Attachment: thrift-209.patch
> TTransportFactory can't be subclassed properly
> ----------------------------------------------
>
> Key: THRIFT-209
> URL: https://issues.apache.org/jira/browse/THRIFT-209
> Project: Thrift
> Issue Type: Bug
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Attachments: thrift-209.patch
>
>
> The TTransportFactory.GetTransport method is not declared as virtual, preventing it from being overriden in subclasses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-209) TTransportFactory can't be subclassed
properly
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-209:
-------------------------------
Comment: was deleted
> TTransportFactory can't be subclassed properly
> ----------------------------------------------
>
> Key: THRIFT-209
> URL: https://issues.apache.org/jira/browse/THRIFT-209
> Project: Thrift
> Issue Type: Bug
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Attachments: thrift-209.patch
>
>
> The TTransportFactory.GetTransport method is not declared as virtual, preventing it from being overriden in subclasses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-209) TTransportFactory can't be
subclassed properly
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658963#action_12658963 ]
Michael Greene commented on THRIFT-209:
---------------------------------------
+1
> TTransportFactory can't be subclassed properly
> ----------------------------------------------
>
> Key: THRIFT-209
> URL: https://issues.apache.org/jira/browse/THRIFT-209
> Project: Thrift
> Issue Type: Bug
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Attachments: thrift-209.patch
>
>
> The TTransportFactory.GetTransport method is not declared as virtual, preventing it from being overriden in subclasses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-209) TTransportFactory can't be subclassed
properly
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss resolved THRIFT-209.
--------------------------------
Resolution: Fixed
r739628
> TTransportFactory can't be subclassed properly
> ----------------------------------------------
>
> Key: THRIFT-209
> URL: https://issues.apache.org/jira/browse/THRIFT-209
> Project: Thrift
> Issue Type: Bug
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Attachments: thrift-209.patch
>
>
> The TTransportFactory.GetTransport method is not declared as virtual, preventing it from being overriden in subclasses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-209) TTransportFactory can't be
subclassed properly
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658641#action_12658641 ]
Esteve Fernandez commented on THRIFT-209:
-----------------------------------------
Any update? The patch is pretty small and doesn't cause any side effect.
> TTransportFactory can't be subclassed properly
> ----------------------------------------------
>
> Key: THRIFT-209
> URL: https://issues.apache.org/jira/browse/THRIFT-209
> Project: Thrift
> Issue Type: Bug
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Attachments: thrift-209.patch
>
>
> The TTransportFactory.GetTransport method is not declared as virtual, preventing it from being overriden in subclasses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-209) TTransportFactory can't be subclassed
properly
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Esteve Fernandez reassigned THRIFT-209:
---------------------------------------
Assignee: Esteve Fernandez
> TTransportFactory can't be subclassed properly
> ----------------------------------------------
>
> Key: THRIFT-209
> URL: https://issues.apache.org/jira/browse/THRIFT-209
> Project: Thrift
> Issue Type: Bug
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Attachments: thrift-209.patch
>
>
> The TTransportFactory.GetTransport method is not declared as virtual, preventing it from being overriden in subclasses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-209) TTransportFactory can't be
subclassed properly
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662792#action_12662792 ]
Esteve Fernandez commented on THRIFT-209:
-----------------------------------------
I meant "apply the patch and close this issue".
> TTransportFactory can't be subclassed properly
> ----------------------------------------------
>
> Key: THRIFT-209
> URL: https://issues.apache.org/jira/browse/THRIFT-209
> Project: Thrift
> Issue Type: Bug
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Attachments: thrift-209.patch
>
>
> The TTransportFactory.GetTransport method is not declared as virtual, preventing it from being overriden in subclasses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-209) TTransportFactory can't be
subclassed properly
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663729#action_12663729 ]
Esteve Fernandez commented on THRIFT-209:
-----------------------------------------
More info about the virtual keyword: http://msdn.microsoft.com/en-us/library/9fkccyh4(VS.80).aspx
_The virtual keyword is used to modify a method, property, indexer or event declaration, and allow it to be overridden in a derived class._
The patch is ridiculously small, I can't see any side effects if applied.
> TTransportFactory can't be subclassed properly
> ----------------------------------------------
>
> Key: THRIFT-209
> URL: https://issues.apache.org/jira/browse/THRIFT-209
> Project: Thrift
> Issue Type: Bug
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Attachments: thrift-209.patch
>
>
> The TTransportFactory.GetTransport method is not declared as virtual, preventing it from being overriden in subclasses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-209) TTransportFactory can't be
subclassed properly
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662787#action_12662787 ]
Esteve Fernandez commented on THRIFT-209:
-----------------------------------------
There's already a positive review (thanks Michael!), could someone please apply it and close this issue?
> TTransportFactory can't be subclassed properly
> ----------------------------------------------
>
> Key: THRIFT-209
> URL: https://issues.apache.org/jira/browse/THRIFT-209
> Project: Thrift
> Issue Type: Bug
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Attachments: thrift-209.patch
>
>
> The TTransportFactory.GetTransport method is not declared as virtual, preventing it from being overriden in subclasses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.