You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/27 02:38:45 UTC
[GitHub] [pulsar] Demogorgon314 opened a new pull request, #15340: [Improve][doc] Add config of IO and acceptor threads in proxy
Demogorgon314 opened a new pull request, #15340:
URL: https://github.com/apache/pulsar/pull/15340
### Motivation
Add docs for PR #14054
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `no-need-doc`
(Please explain why)
- [x] `doc`
(Your PR contains doc changes)
- [ ] `doc-added`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #15340: [Improve][doc] Add config of IO and acceptor threads in proxy
Posted by GitBox <gi...@apache.org>.
lhotari merged PR #15340:
URL: https://github.com/apache/pulsar/pull/15340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Demogorgon314 commented on pull request #15340: [Improve][doc] Add config of IO and acceptor threads in proxy
Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on PR #15340:
URL: https://github.com/apache/pulsar/pull/15340#issuecomment-1110521111
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #15340: [Improve][doc] Add config of IO and acceptor threads in proxy
Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on code in PR #15340:
URL: https://github.com/apache/pulsar/pull/15340#discussion_r859472439
##########
site2/docs/reference-configuration.md:
##########
@@ -817,6 +817,8 @@ The [Pulsar proxy](concepts-architecture-overview.md#pulsar-proxy) can be config
|tokenAudienceClaim| The token audience "claim" name, e.g. "aud". It is used to get the audience from token. If it is not set, the audience is not verified. ||
| tokenAudience | The token audience stands for this broker. The field `tokenAudienceClaim` of a valid token need contains this parameter.| |
|haProxyProtocolEnabled | Enable or disable the [HAProxy](http://www.haproxy.org/) protocol. |false|
+| numIOThreads | Number of threads to use for Netty IO. | 2 * Runtime.getRuntime().availableProcessors() |
Review Comment:
https://github.com/apache/pulsar/blob/c24a6615f7190615f54b2cbf6d2612488c96a33b/site2/docs/reference-configuration.md?plain=1#L486
I think we should use the same description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Demogorgon314 commented on pull request #15340: [Improve][doc] Add config of IO and acceptor threads in proxy
Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on PR #15340:
URL: https://github.com/apache/pulsar/pull/15340#issuecomment-1112097934
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15340: [Improve][doc] Add config of IO and acceptor threads in proxy
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #15340:
URL: https://github.com/apache/pulsar/pull/15340#discussion_r859460276
##########
site2/docs/reference-configuration.md:
##########
@@ -817,6 +817,8 @@ The [Pulsar proxy](concepts-architecture-overview.md#pulsar-proxy) can be config
|tokenAudienceClaim| The token audience "claim" name, e.g. "aud". It is used to get the audience from token. If it is not set, the audience is not verified. ||
| tokenAudience | The token audience stands for this broker. The field `tokenAudienceClaim` of a valid token need contains this parameter.| |
|haProxyProtocolEnabled | Enable or disable the [HAProxy](http://www.haproxy.org/) protocol. |false|
+| numIOThreads | Number of threads to use for Netty IO. | 2 * Runtime.getRuntime().availableProcessors() |
Review Comment:
```suggestion
| numIOThreads | Number of threads used for Netty IO. | 2 * Runtime.getRuntime().availableProcessors() |
```
do you mean this?
##########
site2/docs/reference-configuration.md:
##########
@@ -817,6 +817,8 @@ The [Pulsar proxy](concepts-architecture-overview.md#pulsar-proxy) can be config
|tokenAudienceClaim| The token audience "claim" name, e.g. "aud". It is used to get the audience from token. If it is not set, the audience is not verified. ||
| tokenAudience | The token audience stands for this broker. The field `tokenAudienceClaim` of a valid token need contains this parameter.| |
|haProxyProtocolEnabled | Enable or disable the [HAProxy](http://www.haproxy.org/) protocol. |false|
+| numIOThreads | Number of threads to use for Netty IO. | 2 * Runtime.getRuntime().availableProcessors() |
+| numAcceptorThreads | Number of threads to use for Netty Acceptor. | 1 |
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #15340: [Improve][doc] Add config of IO and acceptor threads in proxy
Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on code in PR #15340:
URL: https://github.com/apache/pulsar/pull/15340#discussion_r860404360
##########
conf/proxy.conf:
##########
@@ -72,6 +72,12 @@ webServicePort=8080
# Port to use to server HTTPS request
webServicePortTls=
+# Number of threads to use for Netty IO. Default is set to `2 * Runtime.getRuntime().availableProcessors()`
+numIOThreads=
+
+# Number of threads to use for Netty Acceptor. Default is set to `1`
Review Comment:
Thanks. Fixed : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15340: [Improve][doc] Add config of IO and acceptor threads in proxy
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #15340:
URL: https://github.com/apache/pulsar/pull/15340#discussion_r860400535
##########
conf/proxy.conf:
##########
@@ -72,6 +72,12 @@ webServicePort=8080
# Port to use to server HTTPS request
webServicePortTls=
+# Number of threads to use for Netty IO. Default is set to `2 * Runtime.getRuntime().availableProcessors()`
+numIOThreads=
+
+# Number of threads to use for Netty Acceptor. Default is set to `1`
Review Comment:
same
pls check all occurrences
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #15340: [Improve][doc] Add config of IO and acceptor threads in proxy
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #15340:
URL: https://github.com/apache/pulsar/pull/15340#issuecomment-1112813060
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #15340: [Improve][doc] Add config of IO and acceptor threads in proxy
Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on code in PR #15340:
URL: https://github.com/apache/pulsar/pull/15340#discussion_r859472439
##########
site2/docs/reference-configuration.md:
##########
@@ -817,6 +817,8 @@ The [Pulsar proxy](concepts-architecture-overview.md#pulsar-proxy) can be config
|tokenAudienceClaim| The token audience "claim" name, e.g. "aud". It is used to get the audience from token. If it is not set, the audience is not verified. ||
| tokenAudience | The token audience stands for this broker. The field `tokenAudienceClaim` of a valid token need contains this parameter.| |
|haProxyProtocolEnabled | Enable or disable the [HAProxy](http://www.haproxy.org/) protocol. |false|
+| numIOThreads | Number of threads to use for Netty IO. | 2 * Runtime.getRuntime().availableProcessors() |
Review Comment:
https://github.com/apache/pulsar/blob/c24a6615f7190615f54b2cbf6d2612488c96a33b/site2/docs/reference-configuration.md?plain=1#L486-L487
I think we should use the same description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #15340: [Improve][doc] Add config of IO and acceptor threads in proxy
Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on code in PR #15340:
URL: https://github.com/apache/pulsar/pull/15340#discussion_r860399246
##########
site2/docs/reference-configuration.md:
##########
@@ -817,6 +817,8 @@ The [Pulsar proxy](concepts-architecture-overview.md#pulsar-proxy) can be config
|tokenAudienceClaim| The token audience "claim" name, e.g. "aud". It is used to get the audience from token. If it is not set, the audience is not verified. ||
| tokenAudience | The token audience stands for this broker. The field `tokenAudienceClaim` of a valid token need contains this parameter.| |
|haProxyProtocolEnabled | Enable or disable the [HAProxy](http://www.haproxy.org/) protocol. |false|
+| numIOThreads | Number of threads used for Netty IO. | 2 * Runtime.getRuntime().availableProcessors() |
+| numAcceptorThreads | Number of threads to use for Netty Acceptor. | 1 |
Review Comment:
```suggestion
| numAcceptorThreads | Number of threads used for Netty Acceptor. | 1 |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15340: [Improve][doc] Add config of IO and acceptor threads in proxy
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #15340:
URL: https://github.com/apache/pulsar/pull/15340#discussion_r860395844
##########
site2/docs/reference-configuration.md:
##########
@@ -817,6 +817,8 @@ The [Pulsar proxy](concepts-architecture-overview.md#pulsar-proxy) can be config
|tokenAudienceClaim| The token audience "claim" name, e.g. "aud". It is used to get the audience from token. If it is not set, the audience is not verified. ||
| tokenAudience | The token audience stands for this broker. The field `tokenAudienceClaim` of a valid token need contains this parameter.| |
|haProxyProtocolEnabled | Enable or disable the [HAProxy](http://www.haproxy.org/) protocol. |false|
+| numIOThreads | Number of threads to use for Netty IO. | 2 * Runtime.getRuntime().availableProcessors() |
Review Comment:
I think the description there is inaccurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #15340: [Improve][doc] Add config of IO and acceptor threads in proxy
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #15340:
URL: https://github.com/apache/pulsar/pull/15340#issuecomment-1118321394
@Demogorgon314 can you resolve the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org