You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/01/11 13:34:32 UTC

[GitHub] [incubator-apisix] agile6v opened a new pull request #1039: enhancement: check if uri option starts with "/ in proxy-rewrite plugin.

agile6v opened a new pull request #1039: enhancement: check if uri option starts with "/ in proxy-rewrite plugin.
URL: https://github.com/apache/incubator-apisix/pull/1039
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on issue #1039: enhancement: check if uri option starts with "/ in proxy-rewrite plugin.

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1039: enhancement: check if uri option starts with "/ in proxy-rewrite plugin.
URL: https://github.com/apache/incubator-apisix/pull/1039#issuecomment-573370455
 
 
   https://github.com/agile6v/incubator-apisix/blob/8cc4420646d958513136eb6e2b013f833b24957e/lua/apisix/plugins/proxy-rewrite.lua#L30
   
   We can check it in schema with the `pattern` of `string` object.
   
   https://json-schema.org/draft/2019-09/json-schema-validation.html#rfc.section.6.3.3

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming merged pull request #1039: enhancement: check if uri option starts with "/ in proxy-rewrite plugin.

Posted by GitBox <gi...@apache.org>.
moonming merged pull request #1039: enhancement: check if uri option starts with "/ in proxy-rewrite plugin.
URL: https://github.com/apache/incubator-apisix/pull/1039
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] agile6v commented on issue #1039: enhancement: check if uri option starts with "/ in proxy-rewrite plugin.

Posted by GitBox <gi...@apache.org>.
agile6v commented on issue #1039: enhancement: check if uri option starts with "/ in proxy-rewrite plugin.
URL: https://github.com/apache/incubator-apisix/pull/1039#issuecomment-573377275
 
 
   I submit another PR. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services