[GitHub] dongeforever commented on a change in pull request #72: [ROCKETMQ-134]the offset of message filter by tags may be not commit to broker

[gi...@git.apache.org]

dongeforever commented on a change in pull request #72: [ROCKETMQ-134]the offset of message filter by tags may be not commit to broker
URL: https://github.com/apache/incubator-rocketmq/pull/72#discussion_r140949236
 
 

 ##########
 File path: client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java
 ##########
 @@ -280,6 +280,12 @@ public void onSuccess(PullResult pullResult) {
 
                     switch (pullResult.getPullStatus()) {
                         case FOUND:
+                            if (pullResult.getMsgFoundList().size() == 0) {
 
 Review comment:
   It maybe confusing without comments.
   For if the status is FOUND, it is expected that the msgList size will be greater than 0.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services