You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "lostluck (via GitHub)" <gi...@apache.org> on 2023/02/17 20:26:52 UTC
[GitHub] [beam] lostluck opened a new pull request, #25545: Update Go SDK version to 1.19
lostluck opened a new pull request, #25545:
URL: https://github.com/apache/beam/pull/25545
New dependencies have required the Go SDK version to be increased to 1.19 at minimum, which is the current trailing stable Go version.
Users are likely already on 1.20 by now, so this largely affects Beam infra, which has also been updated in this PR.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #25545: Update Go SDK minimum Go version to 1.19
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #25545:
URL: https://github.com/apache/beam/pull/25545#issuecomment-1435365588
The last change everything but the go tests passed, and the last change only affected the Go tests.
This should be safe to merge, but I'll keep an eye on the postcommit runs just in case, so we can roll it back promptly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #25545: Update Go SDK version to 1.19
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #25545:
URL: https://github.com/apache/beam/pull/25545#issuecomment-1435238179
# [Codecov](https://codecov.io/gh/apache/beam/pull/25545?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#25545](https://codecov.io/gh/apache/beam/pull/25545?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2d2408d) into [master](https://codecov.io/gh/apache/beam/commit/20c8d3a2ba11f3965022e2ba5e12a241a4ec3442?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (20c8d3a) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 2d2408d differs from pull request most recent head 4b4ec9c. Consider uploading reports for the commit 4b4ec9c to get more accurate results
```diff
@@ Coverage Diff @@
## master #25545 +/- ##
=======================================
Coverage 72.80% 72.80%
=======================================
Files 750 750
Lines 99314 99314
=======================================
Hits 72304 72304
Misses 25648 25648
Partials 1362 1362
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #25545: Update Go SDK minimum Go version to 1.19
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck merged PR #25545:
URL: https://github.com/apache/beam/pull/25545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #25545: Update Go SDK minimum Go version to 1.19
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #25545:
URL: https://github.com/apache/beam/pull/25545#issuecomment-1435261575
Given the breadth of effect, I'm going to wait for the various test runs to complete first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #25545: Update Go SDK version to 1.19
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #25545:
URL: https://github.com/apache/beam/pull/25545#issuecomment-1435230669
R: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org