[GitHub] [arrow-datafusion] jgoday commented on a change in pull request #687: #554: Lead/lag window function with offset and default value arguments

[GitBox <gi...@apache.org>]

jgoday commented on a change in pull request #687:
URL: https://github.com/apache/arrow-datafusion/pull/687#discussion_r664537113



##########
File path: datafusion/src/physical_plan/type_coercion.rs
##########
@@ -131,7 +131,10 @@ fn get_valid_types(
         Signature::OneOf(types) => {
             let mut r = vec![];
             for s in types {
-                r.extend(get_valid_types(s, current_types)?);
+                if let Ok(valid_types) = get_valid_types(s, current_types) {

Review comment:
       Maybe I have misunderstood it, but in the original code, if one of the signatures within OneOf fails then the whole get_valid_types returns an error, isn't it ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org