You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/09/01 18:56:22 UTC
[GitHub] [superset] justinpark opened a new pull request, #21300: feat(sqllab): Make LeftBar with resizable
justinpark opened a new pull request, #21300:
URL: https://github.com/apache/superset/pull/21300
### SUMMARY
_following feedback from #21280_
Since the #21280 can cover too much space, this commit makes the sidebar width fixed and collapsed the overflowing items as well.
As #20778 introduces the resizable menu on dashboard, this commit also introduces the resizable feature so user can expend the width to check the full text on demand.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
- Before:
https://user-images.githubusercontent.com/1392866/187795286-045e9f52-5223-4bd5-a95c-da9e3ae794a2.mov
- After:
https://user-images.githubusercontent.com/1392866/187991177-6e5bd395-07f0-4ba2-9347-eced000d95b7.mov
### TESTING INSTRUCTIONS
- Go to sqllab
- Hover over the left bar divider
- Drag and drop
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
cc: @EugeneTorap @ktmud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #21300: feat(sqllab): Make LeftBar width resizable
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on PR #21300:
URL: https://github.com/apache/superset/pull/21300#issuecomment-1234769067
Like it π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21300: feat(sqllab): Make LeftBar width resizable
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21300:
URL: https://github.com/apache/superset/pull/21300#issuecomment-1234764347
# [Codecov](https://codecov.io/gh/apache/superset/pull/21300?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21300](https://codecov.io/gh/apache/superset/pull/21300?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (969a1fd) into [master](https://codecov.io/gh/apache/superset/commit/65a11b6f457ea730cc07a38bfb176c000a29ce46?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (65a11b6) will **increase** coverage by `11.57%`.
> The diff coverage is `84.00%`.
> :exclamation: Current head 969a1fd differs from pull request most recent head dfa7285. Consider uploading reports for the commit dfa7285 to get more accurate results
```diff
@@ Coverage Diff @@
## master #21300 +/- ##
===========================================
+ Coverage 54.86% 66.43% +11.57%
===========================================
Files 1786 1787 +1
Lines 68267 68279 +12
Branches 7264 7266 +2
===========================================
+ Hits 37454 45362 +7908
+ Misses 28943 21045 -7898
- Partials 1870 1872 +2
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `52.48% <84.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21300?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...d/src/SqlLab/components/TabbedSqlEditors/index.jsx](https://codecov.io/gh/apache/superset/pull/21300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMvaW5kZXguanN4) | `55.17% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/utils/localStorageHelpers.ts](https://codecov.io/gh/apache/superset/pull/21300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2xvY2FsU3RvcmFnZUhlbHBlcnMudHM=) | `90.00% <ΓΈ> (ΓΈ)` | |
| [...d/components/DashboardBuilder/DashboardBuilder.tsx](https://codecov.io/gh/apache/superset/pull/21300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIvRGFzaGJvYXJkQnVpbGRlci50c3g=) | `75.24% <50.00%> (+0.24%)` | :arrow_up: |
| [...frontend/src/SqlLab/components/SqlEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/21300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci9pbmRleC5qc3g=) | `51.41% <77.77%> (+0.82%)` | :arrow_up: |
| [...frontend/src/components/ResizableSidebar/index.tsx](https://codecov.io/gh/apache/superset/pull/21300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVzaXphYmxlU2lkZWJhci9pbmRleC50c3g=) | `83.33% <83.33%> (ΓΈ)` | |
| [superset-frontend/src/SqlLab/constants.ts](https://codecov.io/gh/apache/superset/pull/21300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb25zdGFudHMudHM=) | `100.00% <100.00%> (ΓΈ)` | |
| [...mponents/ResizableSidebar/useStoredSidebarWidth.ts](https://codecov.io/gh/apache/superset/pull/21300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVzaXphYmxlU2lkZWJhci91c2VTdG9yZWRTaWRlYmFyV2lkdGgudHM=) | `100.00% <100.00%> (ΓΈ)` | |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/21300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `78.49% <100.00%> (+0.23%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/21300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.61% <0.00%> (+0.64%)` | :arrow_up: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/21300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `31.36% <0.00%> (+0.90%)` | :arrow_up: |
| ... and [290 more](https://codecov.io/gh/apache/superset/pull/21300/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: Weβre building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud merged pull request #21300: feat(sqllab): Make LeftBar width resizable
Posted by GitBox <gi...@apache.org>.
ktmud merged PR #21300:
URL: https://github.com/apache/superset/pull/21300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on pull request #21300: feat(sqllab): Make LeftBar width resizable
Posted by GitBox <gi...@apache.org>.
justinpark commented on PR #21300:
URL: https://github.com/apache/superset/pull/21300#issuecomment-1234672149
cc: @nytai for visibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org