You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by yo...@apache.org on 2019/08/09 13:03:52 UTC

[lucene-solr] branch master updated: SOLR-13399: fix splitByPrefix default to be false

This is an automated email from the ASF dual-hosted git repository.

yonik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/master by this push:
     new 2e5c554  SOLR-13399: fix splitByPrefix default to be false
2e5c554 is described below

commit 2e5c554fea0aea1dfeecb227777f03f18fb78cd4
Author: yonik <yo...@apache.org>
AuthorDate: Fri Aug 9 09:05:05 2019 -0400

    SOLR-13399: fix splitByPrefix default to be false
---
 .../src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java   | 2 +-
 .../core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java b/solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java
index 6c5921e..f18b0b6 100644
--- a/solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java
+++ b/solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java
@@ -209,7 +209,7 @@ public class SplitShardCmd implements OverseerCollectionMessageHandler.Cmd {
       ShardHandler shardHandler = ocmh.shardHandlerFactory.getShardHandler(ocmh.overseer.getCoreContainer().getUpdateShardHandler().getDefaultHttpClient());
 
 
-      if (message.getBool(CommonAdminParams.SPLIT_BY_PREFIX, true)) {
+      if (message.getBool(CommonAdminParams.SPLIT_BY_PREFIX, false)) {
         t = timings.sub("getRanges");
 
         ModifiableSolrParams params = new ModifiableSolrParams();
diff --git a/solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java b/solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java
index c08805d..1e31577 100644
--- a/solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java
+++ b/solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java
@@ -152,6 +152,7 @@ import static org.apache.solr.common.params.CommonAdminParams.NUM_SUB_SHARDS;
 import static org.apache.solr.common.params.CommonAdminParams.SPLIT_FUZZ;
 import static org.apache.solr.common.params.CommonAdminParams.SPLIT_METHOD;
 import static org.apache.solr.common.params.CommonAdminParams.WAIT_FOR_FINAL_STATE;
+import static org.apache.solr.common.params.CommonAdminParams.SPLIT_BY_PREFIX;
 import static org.apache.solr.common.params.CommonParams.NAME;
 import static org.apache.solr.common.params.CommonParams.TIMING;
 import static org.apache.solr.common.params.CommonParams.VALUE_LONG;
@@ -775,6 +776,7 @@ public class CollectionsHandler extends RequestHandlerBase implements Permission
           SPLIT_METHOD,
           NUM_SUB_SHARDS,
           SPLIT_FUZZ,
+          SPLIT_BY_PREFIX,
           FOLLOW_ALIASES);
       return copyPropertiesWithPrefix(req.getParams(), map, COLL_PROP_PREFIX);
     }),