You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/04/11 21:29:00 UTC
[jira] [Commented] (GEODE-4637) Geode Native uses GEODE rather than
GEODE_HOME
[ https://issues.apache.org/jira/browse/GEODE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434596#comment-16434596 ]
ASF subversion and git services commented on GEODE-4637:
--------------------------------------------------------
Commit c030242c198f16bb2aee9781240a603ec55fbef2 in geode-native's branch refs/heads/develop from [~mmartell]
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=c030242 ]
GEODE-4637: Allow only GEODE_HOME, remove GEODE (#268)
* Updated build instructions and find module to allow GEODE_HOME as env var and GEODE_ROOT cmake var
> Geode Native uses GEODE rather than GEODE_HOME
> ----------------------------------------------
>
> Key: GEODE-4637
> URL: https://issues.apache.org/jira/browse/GEODE-4637
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Addison
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The java side of things uses {{GEODE_HOME}} environment variable to point to the Geode install directory containing the /bin.
> [https://github.com/apache/geode-examples/blob/5b413a34e30790a6631332cfa1f4b485a487abcb/build.gradle]
> Geode Native uses the environment variable GEODE.
> [https://github.com/apache/geode-native/blob/develop/BUILDING.md]
> This is confusing. It would be best if we standardize on {{GEODE_HOME}}.
>
> This does not mean changing the FindGeode.cmake module's {{GEODE_ROOT}} configuration variable. The only change should be in which environment variable is used to search for Geode if the {{GEODE_ROOT}} is not explicitly set.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)