You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Vladimir Sitnikov (Jira)" <ji...@apache.org> on 2020/04/02 05:55:00 UTC

[jira] [Commented] (CALCITE-3892) Make junit test classes and methods non-public

    [ https://issues.apache.org/jira/browse/CALCITE-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073394#comment-17073394 ] 

Vladimir Sitnikov commented on CALCITE-3892:
--------------------------------------------

I think it is not worth doing.
This change will update lots of files with no benefit.

We should stop publishing test.jar artifacts, then it does not matter if class is public or not. 

> Make junit test classes and methods non-public
> ----------------------------------------------
>
>                 Key: CALCITE-3892
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3892
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Priority: Major
>
> In junit 4 and earlier versions, junit classes and methods must be public. In junit 5 (jupiter) this is no longer the case.
> This change makes classes and methods package-protected where possible (i.e. removes the "public" modifier). It makes tests a bit more concise, and gives us more freedom to refactor tests in future.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)