You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by tianxuan911 <gi...@git.apache.org> on 2016/07/10 09:54:34 UTC
[GitHub] spark pull request #14125: New Feature!
GitHub user tianxuan911 opened a pull request:
https://github.com/apache/spark/pull/14125
New Feature!
Configure file named slaves in directory conf support ssh param custom!
Before this commit,only username and ip.Such as
locahost
name@localhost
After, looks like in shell
-p 23229 name@localhost
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tianxuan911/spark 1.6-newfeature-slaves-support-ssh-param-custom
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14125.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14125
----
commit a007d8c9f161f7c95516d2be8cf19a9e14a8b4fa
Author: 田旋 <ti...@sandwish.cn>
Date: 2016-07-10T09:48:59Z
New Feature!
Configure file named slaves in directory conf support ssh param custom!
Before this commit,only username and ip.Such as
locahost
name@localhost
After, looks like in shell
-p 23229 name@localhost
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14125: New Feature!
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14125: New Feature!
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14125
There's enough wrong with this PR that you need to close it, then read https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14125: New Feature!
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14125
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14125: New Feature!
Posted by tianxuan911 <gi...@git.apache.org>.
Github user tianxuan911 commented on the issue:
https://github.com/apache/spark/pull/14125
I'm realy sorry for my mistake\uff01Recently ,i'm reading "Contributing to Spark".
Thanks for your help.@srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org