You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Sean Owen (JIRA)" <ji...@apache.org> on 2016/06/10 14:33:21 UTC
[jira] [Commented] (SPARK-15875) Avoid using Seq.length == 0 and
Seq.lenth > 0. Use Seq.isEmpty and Seq.nonEmpty instead.
[ https://issues.apache.org/jira/browse/SPARK-15875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15324527#comment-15324527 ]
Sean Owen commented on SPARK-15875:
-----------------------------------
I certainly agree where there is a performance impact. Go for it.
> Avoid using Seq.length == 0 and Seq.lenth > 0. Use Seq.isEmpty and Seq.nonEmpty instead.
> ----------------------------------------------------------------------------------------
>
> Key: SPARK-15875
> URL: https://issues.apache.org/jira/browse/SPARK-15875
> Project: Spark
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Yang Wang
> Priority: Minor
>
> In scala, immutable.List.length is an expensive operation so we should
> avoid using Seq.length == 0 and Seq.lenth > 0 and use Seq.isEmpty and Seq.nonEmpty instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org