You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/11/16 04:43:17 UTC
[kudu-CR](branch-1.11.x) [docs] WARN AS ERROR requires doxygen >= 1.8.11
Hello Kudu Jenkins, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14729
to review the following change.
Change subject: [docs] WARN_AS_ERROR requires doxygen >= 1.8.11
......................................................................
[docs] WARN_AS_ERROR requires doxygen >= 1.8.11
The doxygen's WARN_AS_ERROR configuration parameter was introduced with
version 1.8.11 released December 30, 2015. Since that was relatively
long time ago and the doxygen tool is needed only when building
Kudu C++ client API documentation, I think it's OK to require a
relatively fresh version of the doxygen tool.
Information on the version of the pre-packaged doxygen tool available
supported popular Linux distributions (except for SLES):
OS version (codename) | doxygen version
-----------------------------------------
RHEL/CentOS 6.6 | 1.6.1
RHEL/CentOS 6.10 | 1.6.1
RHEL/CentOS 7.5 | 1.8.5
Debian 8 (jessie) | 1.8.8
Debian 9 (stretch) | 1.8.13
Ubuntu 14.04 (trusty) | 1.8.6
Ubuntu 16.04 (xenial) | 1.8.11
Ubuntu 18.04 (bionic) | 1.8.13
This is a follow-up for 6064884950f7bb5cb5ca1c4767ac0f34e1c631c9.
Change-Id: I7f2cfc0a9765ee0641f1cf0138ce92e54d18ce96
Reviewed-on: http://gerrit.cloudera.org:8080/11832
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit b293343df44c0d002bb4dd3ce6334d03e7197124)
---
M CMakeLists.txt
M docs/developing.adoc
2 files changed, 9 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/14729/1
--
To view, visit http://gerrit.cloudera.org:8080/14729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f2cfc0a9765ee0641f1cf0138ce92e54d18ce96
Gerrit-Change-Number: 14729
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.11.x) [docs] WARN AS ERROR requires doxygen >= 1.8.11
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14729 )
Change subject: [docs] WARN_AS_ERROR requires doxygen >= 1.8.11
......................................................................
[docs] WARN_AS_ERROR requires doxygen >= 1.8.11
The doxygen's WARN_AS_ERROR configuration parameter was introduced with
version 1.8.11 released December 30, 2015. Since that was relatively
long time ago and the doxygen tool is needed only when building
Kudu C++ client API documentation, I think it's OK to require a
relatively fresh version of the doxygen tool.
Information on the version of the pre-packaged doxygen tool available
supported popular Linux distributions (except for SLES):
OS version (codename) | doxygen version
-----------------------------------------
RHEL/CentOS 6.6 | 1.6.1
RHEL/CentOS 6.10 | 1.6.1
RHEL/CentOS 7.5 | 1.8.5
Debian 8 (jessie) | 1.8.8
Debian 9 (stretch) | 1.8.13
Ubuntu 14.04 (trusty) | 1.8.6
Ubuntu 16.04 (xenial) | 1.8.11
Ubuntu 18.04 (bionic) | 1.8.13
This is a follow-up for 6064884950f7bb5cb5ca1c4767ac0f34e1c631c9.
Change-Id: I7f2cfc0a9765ee0641f1cf0138ce92e54d18ce96
Reviewed-on: http://gerrit.cloudera.org:8080/11832
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit b293343df44c0d002bb4dd3ce6334d03e7197124)
Reviewed-on: http://gerrit.cloudera.org:8080/14729
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M CMakeLists.txt
M docs/developing.adoc
2 files changed, 9 insertions(+), 6 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f2cfc0a9765ee0641f1cf0138ce92e54d18ce96
Gerrit-Change-Number: 14729
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.11.x) [docs] WARN AS ERROR requires doxygen >= 1.8.11
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14729 )
Change subject: [docs] WARN_AS_ERROR requires doxygen >= 1.8.11
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f2cfc0a9765ee0641f1cf0138ce92e54d18ce96
Gerrit-Change-Number: 14729
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 16 Nov 2019 06:22:09 +0000
Gerrit-HasComments: No