You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ja...@apache.org on 2019/10/25 06:46:03 UTC

[flink] branch release-1.9 updated: [FLINK-14524] [flink-jdbc] Fix syntax for PostgreSQL dialect "upsert" statement (#9990)

This is an automated email from the ASF dual-hosted git repository.

jark pushed a commit to branch release-1.9
in repository https://gitbox.apache.org/repos/asf/flink.git


The following commit(s) were added to refs/heads/release-1.9 by this push:
     new 7086a89  [FLINK-14524] [flink-jdbc] Fix syntax for PostgreSQL dialect "upsert" statement (#9990)
7086a89 is described below

commit 7086a8958a40804a604171483d2f374de236cfdf
Author: Fawad Halim <fa...@fawad.net>
AuthorDate: Fri Oct 25 01:40:22 2019 -0500

    [FLINK-14524] [flink-jdbc] Fix syntax for PostgreSQL dialect "upsert" statement (#9990)
---
 .../java/org/apache/flink/api/java/io/jdbc/dialect/JDBCDialects.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/dialect/JDBCDialects.java b/flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/dialect/JDBCDialects.java
index 12e70db..9334ec2 100644
--- a/flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/dialect/JDBCDialects.java
+++ b/flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/dialect/JDBCDialects.java
@@ -129,7 +129,7 @@ public final class JDBCDialects {
 					.map(f -> quoteIdentifier(f) + "=EXCLUDED." + quoteIdentifier(f))
 					.collect(Collectors.joining(", "));
 			return Optional.of(getInsertIntoStatement(tableName, fieldNames) +
-							" ON CONFLICT (" + uniqueColumns +
+							" ON CONFLICT (" + uniqueColumns + ")" +
 							" DO UPDATE SET " + updateClause
 			);
 		}