You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Ting Yao,Huang (Jira)" <ji...@apache.org> on 2021/04/29 10:00:00 UTC
[jira] [Commented] (YUNIKORN-632) Add apache headers to generated
files
[ https://issues.apache.org/jira/browse/YUNIKORN-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17335314#comment-17335314 ]
Ting Yao,Huang commented on YUNIKORN-632:
-----------------------------------------
Committed it.
Thanks. [~weihsiao lin]
> Add apache headers to generated files
> -------------------------------------
>
> Key: YUNIKORN-632
> URL: https://issues.apache.org/jira/browse/YUNIKORN-632
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Components: scheduler-interface
> Reporter: Wilfred Spiegelenburg
> Assignee: Weihsiao Lin
> Priority: Major
> Labels: newbie, pull-request-available
>
> In the SI we generate a number of files which really should have Apache license headers included:
> * si.proto
> * lib/go/common/constants.go
> * lib/go/api/interface.go (after YUNIKORN-490)
> We have control over those files from the top level Makefile and should include the standard apache header.
> The si.pb.go file is generated by protoc-gen.go and does not need a header.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org