You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by charsyam <gi...@git.apache.org> on 2015/06/16 15:46:05 UTC
[GitHub] tajo pull request: TAJO-1647: Change Create Database Tajo Rest API...
GitHub user charsyam opened a pull request:
https://github.com/apache/tajo/pull/604
TAJO-1647: Change Create Database Tajo Rest API address from POST /databases to POST /databases/{database_name}
in Rest API
POST /databases/{database_name} is more understandable
comparing to POST /databases with database_name parameter
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/charsyam/tajo feature/change-api-create-database
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/604.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #604
----
commit 23ea2c3decc95a95d2f7483af84c4bea0d7abbf0
Author: clark.kang <cl...@kakao.com>
Date: 2015-06-16T01:54:59Z
change create database api address
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1647: Change Create Database Tajo Rest API...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/604#issuecomment-114517438
Hi @charsyam, thanks for your patch.
Since I'm not familiar with RESTful API, I would like to ask a question.
Given a create database statement, the ```database_name``` is a variable defined by users.
For such variables, IMHO, passing ```database_name``` as a parameter looks more intuitive.
Are there any conventions in designing RESTful API?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1647: Change Create Database Tajo Rest API...
Posted by charsyam <gi...@git.apache.org>.
Github user charsyam commented on the pull request:
https://github.com/apache/tajo/pull/604#issuecomment-114526846
@jihoonson Hi, jihoon. Thanks for your review :)
You're right. It is not real REST style.
but in my case, POST /databases has only one parameter as its name.
so I think POST /databases/{database-name} is more simple and understable. :)
But, It is not REST API.
so. I don't matter if you close this issue :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1647: Change Create Database Tajo Rest API...
Posted by charsyam <gi...@git.apache.org>.
Github user charsyam closed the pull request at:
https://github.com/apache/tajo/pull/604
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1647: Change Create Database Tajo Rest API...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/604#issuecomment-114781215
Thanks for your comment.
In terms of the consistency of APIs, I think that ```create database``` API should have the equivalent form of ```create table``` API.
So, passing ```database_name``` as a parameter looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---