You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/11/02 21:46:26 UTC
[jira] Created: (CASSANDRA-1698) nodetool cfhistograms
nodetool cfhistograms
---------------------
Key: CASSANDRA-1698
URL: https://issues.apache.org/jira/browse/CASSANDRA-1698
Project: Cassandra
Issue Type: New Feature
Components: Tools
Reporter: Jonathan Ellis
Assignee: Pavel Yaskevich
Fix For: 0.6.7, 0.7.0
we need a nodetool command that outputs columnfamilystore RecentReadLatencyHistogramMicros, RecentReadLatencyHistogramMicros, and (for 0.7) getRecentReadLatencyHistogramMicros.
i'd like this to be in a vertical display with the histogram bucket values from EstimatedHistogram displayed. Like this:
{code}
1 0
15 1
18 542
22 8091
79 198290
114 47248
850 114
1020 37
etc
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1698) nodetool cfhistograms
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932031#action_12932031 ]
Pavel Yaskevich commented on CASSANDRA-1698:
--------------------------------------------
There is an error in the description of this task - "RecentReadLatencyHistogramMicros, RecentReadLatencyHistogramMicros, and (for 0.7) getRecentReadLatencyHistogramMicros." - all the same :)
I will do RecentReadLatencyHistogramMicros, RecentWriteLatencyHistogramMicros for 0.6 and can you please specify what will be added for 0.7?
> nodetool cfhistograms
> ---------------------
>
> Key: CASSANDRA-1698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 0.6.9
>
>
> we need a nodetool command that outputs columnfamilystore RecentReadLatencyHistogramMicros, RecentReadLatencyHistogramMicros, and (for 0.7) getRecentReadLatencyHistogramMicros.
> i'd like this to be in a vertical display with the histogram bucket values from EstimatedHistogram displayed. Like this:
> {code}
> 1 0
> 15 1
> 18 542
> 22 8091
> 79 198290
> 114 47248
> 850 114
> 1020 37
> etc
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1698) nodetool cfhistograms
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Yaskevich updated CASSANDRA-1698:
---------------------------------------
Attachment: CASSANDRA-1698-for-0.6-v2.patch
Shows bucket offsets, formatting fixed, adds method to the NodeProbe to get ColumnFamily MBean instead of iterating
> nodetool cfhistograms
> ---------------------
>
> Key: CASSANDRA-1698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 0.6.9
>
> Attachments: CASSANDRA-1698-for-0.6-v2.patch, CASSANDRA-1698-for-0.6.patch
>
>
> we need a nodetool command that outputs columnfamilystore RecentReadLatencyHistogramMicros, RecentReadLatencyHistogramMicros, and (for 0.7) getRecentReadLatencyHistogramMicros.
> i'd like this to be in a vertical display with the histogram bucket values from EstimatedHistogram displayed. Like this:
> {code}
> 1 0
> 15 1
> 18 542
> 22 8091
> 79 198290
> 114 47248
> 850 114
> 1020 37
> etc
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1698) nodetool cfhistograms
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929024#action_12929024 ]
Brandon Williams commented on CASSANDRA-1698:
---------------------------------------------
For 0.7, the sstable EHs for row size and column count could be useful too.
> nodetool cfhistograms
> ---------------------
>
> Key: CASSANDRA-1698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 0.6.7, 0.7.0
>
>
> we need a nodetool command that outputs columnfamilystore RecentReadLatencyHistogramMicros, RecentReadLatencyHistogramMicros, and (for 0.7) getRecentReadLatencyHistogramMicros.
> i'd like this to be in a vertical display with the histogram bucket values from EstimatedHistogram displayed. Like this:
> {code}
> 1 0
> 15 1
> 18 542
> 22 8091
> 79 198290
> 114 47248
> 850 114
> 1020 37
> etc
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1698) nodetool cfhistograms
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Yaskevich updated CASSANDRA-1698:
---------------------------------------
Attachment: CASSANDRA-1698-for-trunk.patch
This patch is clearly compiles in trunk branch (the latest commit is d498c96b69ec859e3eda802c45088556edccfed3)
> nodetool cfhistograms
> ---------------------
>
> Key: CASSANDRA-1698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 0.6.9
>
> Attachments: CASSANDRA-1698-for-0.6-v2.patch, CASSANDRA-1698-for-0.6.patch, CASSANDRA-1698-for-0.7.patch, CASSANDRA-1698-for-trunk.patch
>
>
> we need a nodetool command that outputs columnfamilystore RecentReadLatencyHistogramMicros, RecentReadLatencyHistogramMicros, and (for 0.7) getRecentReadLatencyHistogramMicros.
> i'd like this to be in a vertical display with the histogram bucket values from EstimatedHistogram displayed. Like this:
> {code}
> 1 0
> 15 1
> 18 542
> 22 8091
> 79 198290
> 114 47248
> 850 114
> 1020 37
> etc
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1698) nodetool cfhistograms
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Yaskevich updated CASSANDRA-1698:
---------------------------------------
Attachment: CASSANDRA-1698-for-0.7.patch
> nodetool cfhistograms
> ---------------------
>
> Key: CASSANDRA-1698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 0.6.9
>
> Attachments: CASSANDRA-1698-for-0.6-v2.patch, CASSANDRA-1698-for-0.6.patch, CASSANDRA-1698-for-0.7.patch
>
>
> we need a nodetool command that outputs columnfamilystore RecentReadLatencyHistogramMicros, RecentReadLatencyHistogramMicros, and (for 0.7) getRecentReadLatencyHistogramMicros.
> i'd like this to be in a vertical display with the histogram bucket values from EstimatedHistogram displayed. Like this:
> {code}
> 1 0
> 15 1
> 18 542
> 22 8091
> 79 198290
> 114 47248
> 850 114
> 1020 37
> etc
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1698) nodetool cfhistograms
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932040#action_12932040 ]
Jonathan Ellis commented on CASSANDRA-1698:
-------------------------------------------
i believe what I intended to say was 0.7 should include the sstables-checked histogram. also brandon's suggestions for row size + column count.
> nodetool cfhistograms
> ---------------------
>
> Key: CASSANDRA-1698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 0.6.9
>
>
> we need a nodetool command that outputs columnfamilystore RecentReadLatencyHistogramMicros, RecentReadLatencyHistogramMicros, and (for 0.7) getRecentReadLatencyHistogramMicros.
> i'd like this to be in a vertical display with the histogram bucket values from EstimatedHistogram displayed. Like this:
> {code}
> 1 0
> 15 1
> 18 542
> 22 8091
> 79 198290
> 114 47248
> 850 114
> 1020 37
> etc
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1698) nodetool cfhistograms
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932541#action_12932541 ]
Hudson commented on CASSANDRA-1698:
-----------------------------------
Integrated in Cassandra-0.6 #6 (See [https://hudson.apache.org/hudson/job/Cassandra-0.6/6/])
add nodetool cfhistogram
patch by Pavel Yaskevich; reviewed by jbellis for CASSANDRA-1698
> nodetool cfhistograms
> ---------------------
>
> Key: CASSANDRA-1698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 0.6.9
>
> Attachments: CASSANDRA-1698-for-0.6-v2.patch, CASSANDRA-1698-for-0.6.patch
>
>
> we need a nodetool command that outputs columnfamilystore RecentReadLatencyHistogramMicros, RecentReadLatencyHistogramMicros, and (for 0.7) getRecentReadLatencyHistogramMicros.
> i'd like this to be in a vertical display with the histogram bucket values from EstimatedHistogram displayed. Like this:
> {code}
> 1 0
> 15 1
> 18 542
> 22 8091
> 79 198290
> 114 47248
> 850 114
> 1020 37
> etc
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1698) nodetool cfhistograms
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932045#action_12932045 ]
Jonathan Ellis commented on CASSANDRA-1698:
-------------------------------------------
you should follow the pattern in NodeProbe of
{code}
public JMXInstrumentedCacheMBean getRowCacheMBean(String tableName, String cfName)
{code}
to grab exactly the requested CFSMbean instead of listing all and iterating.
histogram does not show bucket offsets.
tabs are not going to be adequate to align large numbers.
> nodetool cfhistograms
> ---------------------
>
> Key: CASSANDRA-1698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 0.6.9
>
> Attachments: CASSANDRA-1698-for-0.6.patch
>
>
> we need a nodetool command that outputs columnfamilystore RecentReadLatencyHistogramMicros, RecentReadLatencyHistogramMicros, and (for 0.7) getRecentReadLatencyHistogramMicros.
> i'd like this to be in a vertical display with the histogram bucket values from EstimatedHistogram displayed. Like this:
> {code}
> 1 0
> 15 1
> 18 542
> 22 8091
> 79 198290
> 114 47248
> 850 114
> 1020 37
> etc
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1698) nodetool cfhistograms
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932510#action_12932510 ]
Jonathan Ellis commented on CASSANDRA-1698:
-------------------------------------------
committed to 0.6
> nodetool cfhistograms
> ---------------------
>
> Key: CASSANDRA-1698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 0.6.9
>
> Attachments: CASSANDRA-1698-for-0.6-v2.patch, CASSANDRA-1698-for-0.6.patch
>
>
> we need a nodetool command that outputs columnfamilystore RecentReadLatencyHistogramMicros, RecentReadLatencyHistogramMicros, and (for 0.7) getRecentReadLatencyHistogramMicros.
> i'd like this to be in a vertical display with the histogram bucket values from EstimatedHistogram displayed. Like this:
> {code}
> 1 0
> 15 1
> 18 542
> 22 8091
> 79 198290
> 114 47248
> 850 114
> 1020 37
> etc
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1698) nodetool cfhistograms
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932717#action_12932717 ]
Jonathan Ellis commented on CASSANDRA-1698:
-------------------------------------------
Getting build errors w/ 0.7 patch.
{code}
[javac] /Users/jonathan/projects/cassandra/svn-trunk/src/java/org/apache/cassandra/utils/EstimatedHistogram.java:191: getBucketOffsets() is already defined in org.apache.cassandra.utils.EstimatedHistogram
[javac] public static long[] getBucketOffsets()
[javac] ^
[javac] /Users/jonathan/projects/cassandra/svn-trunk/src/java/org/apache/cassandra/tools/NodeCmd.java:376: printCfHistograms(java.lang.String,java.lang.String,java.io.PrintStream) is already defined in org.apache.cassandra.tools.NodeCmd
[javac] private void printCfHistograms(String keySpace, String columnFamily, PrintStream output)
[javac] ^
[javac] /Users/jonathan/projects/cassandra/svn-trunk/src/java/org/apache/cassandra/utils/EstimatedHistogram.java:193: non-static variable bucketOffsets cannot be referenced from a static context
[javac] return bucketOffsets;
[javac] ^
[javac] /Users/jonathan/projects/cassandra/svn-trunk/src/java/org/apache/cassandra/tools/NodeCmd.java:357: non-static method getBucketOffsets() cannot be referenced from a static context
[javac] long[] offsets = EstimatedHistogram.getBucketOffsets();
[javac] ^
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] 4 errors
{code}
> nodetool cfhistograms
> ---------------------
>
> Key: CASSANDRA-1698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 0.6.9
>
> Attachments: CASSANDRA-1698-for-0.6-v2.patch, CASSANDRA-1698-for-0.6.patch, CASSANDRA-1698-for-0.7.patch
>
>
> we need a nodetool command that outputs columnfamilystore RecentReadLatencyHistogramMicros, RecentReadLatencyHistogramMicros, and (for 0.7) getRecentReadLatencyHistogramMicros.
> i'd like this to be in a vertical display with the histogram bucket values from EstimatedHistogram displayed. Like this:
> {code}
> 1 0
> 15 1
> 18 542
> 22 8091
> 79 198290
> 114 47248
> 850 114
> 1020 37
> etc
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1698) nodetool cfhistograms
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932722#action_12932722 ]
Jonathan Ellis commented on CASSANDRA-1698:
-------------------------------------------
oops, that was vs trunk. applied fine to 0.7. committed there with formatting cleanup.
can you post version of r1035864 for trunk?
> nodetool cfhistograms
> ---------------------
>
> Key: CASSANDRA-1698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 0.6.9
>
> Attachments: CASSANDRA-1698-for-0.6-v2.patch, CASSANDRA-1698-for-0.6.patch, CASSANDRA-1698-for-0.7.patch
>
>
> we need a nodetool command that outputs columnfamilystore RecentReadLatencyHistogramMicros, RecentReadLatencyHistogramMicros, and (for 0.7) getRecentReadLatencyHistogramMicros.
> i'd like this to be in a vertical display with the histogram bucket values from EstimatedHistogram displayed. Like this:
> {code}
> 1 0
> 15 1
> 18 542
> 22 8091
> 79 198290
> 114 47248
> 850 114
> 1020 37
> etc
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1698) nodetool cfhistograms
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932819#action_12932819 ]
Hudson commented on CASSANDRA-1698:
-----------------------------------
Integrated in Cassandra-0.7 #10 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/10/])
add nodetool cfhistogram
patch by Pavel Yaskevich; reviewed by jbellis for CASSANDRA-1698
> nodetool cfhistograms
> ---------------------
>
> Key: CASSANDRA-1698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 0.6.9
>
> Attachments: CASSANDRA-1698-for-0.6-v2.patch, CASSANDRA-1698-for-0.6.patch, CASSANDRA-1698-for-0.7.patch
>
>
> we need a nodetool command that outputs columnfamilystore RecentReadLatencyHistogramMicros, RecentReadLatencyHistogramMicros, and (for 0.7) getRecentReadLatencyHistogramMicros.
> i'd like this to be in a vertical display with the histogram bucket values from EstimatedHistogram displayed. Like this:
> {code}
> 1 0
> 15 1
> 18 542
> 22 8091
> 79 198290
> 114 47248
> 850 114
> 1020 37
> etc
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1698) nodetool cfhistograms
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Yaskevich updated CASSANDRA-1698:
---------------------------------------
Attachment: CASSANDRA-1698-for-0.6.patch
Should I wait until you will merge this with 0.7 branch so I can work on 0.7 specific things?
> nodetool cfhistograms
> ---------------------
>
> Key: CASSANDRA-1698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 0.6.9
>
> Attachments: CASSANDRA-1698-for-0.6.patch
>
>
> we need a nodetool command that outputs columnfamilystore RecentReadLatencyHistogramMicros, RecentReadLatencyHistogramMicros, and (for 0.7) getRecentReadLatencyHistogramMicros.
> i'd like this to be in a vertical display with the histogram bucket values from EstimatedHistogram displayed. Like this:
> {code}
> 1 0
> 15 1
> 18 542
> 22 8091
> 79 198290
> 114 47248
> 850 114
> 1020 37
> etc
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1698) nodetool cfhistograms
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932047#action_12932047 ]
Pavel Yaskevich commented on CASSANDRA-1698:
--------------------------------------------
Oh, sorry I misunderstood description a bit...
> nodetool cfhistograms
> ---------------------
>
> Key: CASSANDRA-1698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1698
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 0.6.9
>
> Attachments: CASSANDRA-1698-for-0.6.patch
>
>
> we need a nodetool command that outputs columnfamilystore RecentReadLatencyHistogramMicros, RecentReadLatencyHistogramMicros, and (for 0.7) getRecentReadLatencyHistogramMicros.
> i'd like this to be in a vertical display with the histogram bucket values from EstimatedHistogram displayed. Like this:
> {code}
> 1 0
> 15 1
> 18 542
> 22 8091
> 79 198290
> 114 47248
> 850 114
> 1020 37
> etc
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.