You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/12 08:36:11 UTC

[GitHub] [tvm] masahi commented on a change in pull request #7980: [METAL] Split kernels and compile them separately

masahi commented on a change in pull request #7980:
URL: https://github.com/apache/tvm/pull/7980#discussion_r630840348



##########
File path: src/runtime/metal/metal_module.mm
##########
@@ -43,7 +44,9 @@
  public:
   explicit MetalModuleNode(std::string data, std::string fmt,
                            std::unordered_map<std::string, FunctionInfo> fmap, std::string source)
-      : data_(data), fmt_(fmt), fmap_(fmap), source_(source) {}
+      : data_(data), fmt_(fmt), fmap_(fmap), source_(source) {
+    parsed_kernels_ = SplitKernels(GetSource(fmt_));

Review comment:
       How about passing `data` directly here to `SplitKernels`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org