[GitHub] [incubator-paimon] liming30 commented on a diff in pull request #876: [flink] Add the compatibility check between StartupMode and LOG_SYSTEM

["liming30 (via GitHub)" <gi...@apache.org>]

liming30 commented on code in PR #876:
URL: https://github.com/apache/incubator-paimon/pull/876#discussion_r1164956861


##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/AbstractFlinkTableFactory.java:
##########
@@ -116,6 +119,12 @@ static Optional<LogStoreTableFactory> createOptionalLogStoreFactory(
             // Use file store continuous reading
             validateFileStoreContinuous(configOptions);
             return Optional.empty();
+        } else if (configOptions.get(SCAN_MODE) == FROM_SNAPSHOT
+                || configOptions.get(SCAN_MODE) == FROM_SNAPSHOT_FULL) {
+            throw new ValidationException(
+                    String.format(
+                            "%s must be null when you use %s for %s",
+                            LOG_SYSTEM.key(), configOptions.get(SCAN_MODE), SCAN_MODE.key()));

Review Comment:
   resolved.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org