You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/28 20:48:17 UTC

[GitHub] [beam] johnjcasey commented on pull request #17455: [BEAM-13250] Factorise gcsio.GcsIO() from gcsfilesystem to allow overriding

johnjcasey commented on PR #17455:
URL: https://github.com/apache/beam/pull/17455#issuecomment-1112640903

   I don't see anything wrong with this change per se, but I think it would make more sense alongside a test change that leverages the new factorization. Do you have a specific test scenario that would be helped by this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org