You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ap...@apache.org on 2020/09/04 17:32:35 UTC

[incubator-pinot] branch master updated: [TE] Adding Holiday Events in helm chart (#5976)

This is an automated email from the ASF dual-hosted git repository.

apucher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 107ec3f  [TE] Adding Holiday Events in helm chart (#5976)
107ec3f is described below

commit 107ec3fbd5611adcc7b09afe8f8384bbf3096132
Author: Suvodeep Pyne <su...@users.noreply.github.com>
AuthorDate: Fri Sep 4 10:32:21 2020 -0700

    [TE] Adding Holiday Events in helm chart (#5976)
    
    ThirdEye allows you to display events from external Google Calendars. To enable this feature,
    simply provide a JSON key. Check https://docs.simplecalendar.io/google-api-key/
    
    ```bash
    ./install.sh  --set-file backend.holidayLoaderKey="/path/to/holiday-loader-key.json"
    ```
---
 kubernetes/helm/thirdeye/README.md                         | 9 +++++++++
 kubernetes/helm/thirdeye/templates/backend/deployment.yaml | 6 ++++++
 kubernetes/helm/thirdeye/templates/common/configmap.yaml   | 8 +++++++-
 3 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/kubernetes/helm/thirdeye/README.md b/kubernetes/helm/thirdeye/README.md
index 688f695..700276e 100644
--- a/kubernetes/helm/thirdeye/README.md
+++ b/kubernetes/helm/thirdeye/README.md
@@ -71,3 +71,12 @@ Alternatively a YAML file that specifies the values for the parameters can be pr
 ```bash
 ./install.sh --name thirdeye -f values.yaml .
 ```
+
+## Holiday Events
+
+ThirdEye allows you to display events from external Google Calendars. To enable this feature, 
+simply provide a JSON key. Check https://docs.simplecalendar.io/google-api-key/
+
+```bash
+./install.sh  --set-file backend.holidayLoaderKey="/path/to/holiday-loader-key.json"
+```
diff --git a/kubernetes/helm/thirdeye/templates/backend/deployment.yaml b/kubernetes/helm/thirdeye/templates/backend/deployment.yaml
index 67d6953..de09771 100644
--- a/kubernetes/helm/thirdeye/templates/backend/deployment.yaml
+++ b/kubernetes/helm/thirdeye/templates/backend/deployment.yaml
@@ -87,6 +87,12 @@ spec:
             mountPath: "/opt/thirdeye/config/pinot-quickstart/persistence.yml"
             subPath: "persistence.yml"
             readOnly: true
+          {{- if .Values.backend.holidayLoaderKey }}
+          - name: thirdeye-config
+            mountPath: "/opt/thirdeye/config/pinot-quickstart/holiday-loader-key.json"
+            subPath: "holiday-loader-key.json"
+            readOnly: true
+          {{- end }}
         resources:
 {{ toYaml .Values.frontend.resources | indent 12 }}
       restartPolicy: Always
diff --git a/kubernetes/helm/thirdeye/templates/common/configmap.yaml b/kubernetes/helm/thirdeye/templates/common/configmap.yaml
index 5498cdb..5647d5d 100644
--- a/kubernetes/helm/thirdeye/templates/common/configmap.yaml
+++ b/kubernetes/helm/thirdeye/templates/common/configmap.yaml
@@ -95,7 +95,7 @@ data:
     #   runFrequency: 10s
 
     classifier: true
-    holidayEventsLoader: true
+    holidayEventsLoader: {{ not .Values.backend.holidayLoaderKey | ternary "false" "true" }}
     monitor: true
     pinotProxy: false
     scheduler: true
@@ -163,6 +163,7 @@ data:
     mockEventsLoader: true
     mockEventsLoaderConfiguration:
       generators:
+        {{- if not .Values.backend.holidayLoaderKey }}
         - type: HOLIDAY
           arrivalType: exponential
           arrivalMean: 86400000
@@ -171,6 +172,7 @@ data:
           seed: 0
           namePrefixes: [First, Second, Third, Last, Funky, Happy, Sad, Glorious, Jolly, Unity, Pinot's]
           nameSuffixes: [day, day, days, celebration, rememberance, occurrence, moment]
+        {{- end }}
         - type: INFORMED
           arrivalType: exponential
           arrivalMean: 43200000
@@ -250,3 +252,7 @@ data:
             trustStoreFilePath: 'trust/store/path/truststore_file' # e.g. '/etc/riddler/cacerts'
             trustStorePassword: ''
         # add your store of choice here
+
+  {{- if .Values.backend.holidayLoaderKey }}
+  holiday-loader-key.json: {{ .Values.backend.holidayLoaderKey | toPrettyJson }}
+  {{- end }}


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org