[jira] [Resolved] (CASSANDRA-6253) Refactor: remove CFDefinition

["Sylvain Lebresne (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CASSANDRA-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sylvain Lebresne resolved CASSANDRA-6253.
-----------------------------------------

    Resolution: Fixed

Committed those fixups with 2 modifications:
# I've removed the addition of the toByteBuffer() method in ColumnIdentifier. The bytes field is public and that's what we use all over the place.
# In the second patch, in isDroppedColumn, we should call getColumnDefinition(), not getColumnDefinitionFromCellName().

Thanks

> Refactor: remove CFDefinition
> -----------------------------
>
>                 Key: CASSANDRA-6253
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6253
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 2.1
>
>         Attachments: 0001-Remove-CFDefinition.txt, 0002-Unit-tests-updates.txt, 0003-Fix-CFDefinition.name-comparisons.txt, 0004-Fix-ColumnIdentifier-Map_Lookup.txt
>
>
> While writing CQL3 initially, we added CFDefinition to be a CQL3-friendly version of CFMetaData. However, a number of changes have it redundant. The infos of CFDefinition are now in CFMetaData in pretty much the same form and in particular CFDefinition.Name is now basically a copy of ColumnDefinition.  This is not only useless, but it is confusing too: sometimes the CQL3 code uses ColumnDefinition because it has too, but more often it uses CFDefinition.Name and both use diferent vocabulary even though they are the exact same thing.
> So this ticket propose to remove CFDefinition and CFDefinition.Name since they are not useful anymore and this clean things up.



--
This message was sent by Atlassian JIRA
(v6.1#6144)