[GitHub] [flink] jinglining edited a comment on issue #11498: [FLINK-16741][WEB] add tm log list & tm log detail page

[GitBox <gi...@apache.org>]

jinglining edited a comment on issue #11498: [FLINK-16741][WEB] add tm log list & tm log detail page
URL: https://github.com/apache/flink/pull/11498#issuecomment-605869888
 
 
   > > it follows the sequence from the restAPI, I can sort it based on the filename or the filesize (not the modify date since not returned by the restAPI), but I'm not sure if it is a good idea.
   > 
   > Lexicographical sort order is problematic if one has a running counter in the filename, such as `-1`, `-2`, `...`, `-10`, `-11` etc; in this case `1`, `10`, `11` will be next to each other.
   > 
   > Sorting descendingly on last modified date could make more sense because a user will be able to see the most recent files first but it needs to be implemented in the REST handler. @jinglining what do you think?
   
   I think it's ok. We could get the last modified from `java.io.File#lastModified`, and sort it.
   Whether we need to add lastModified as a field of  `LogInfo`.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services