You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2014/10/08 22:56:20 UTC

svn commit: r1630230 - in /jmeter/trunk: src/components/org/apache/jmeter/sampler/TestAction.java xdocs/changes.xml

Author: pmouawad
Date: Wed Oct  8 20:56:20 2014
New Revision: 1630230

URL: http://svn.apache.org/r1630230
Log:
Bug 57068 - No error thrown when negative duration is entered in Test Action
Bugzilla Id: 57068

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/sampler/TestAction.java
    jmeter/trunk/xdocs/changes.xml

Modified: jmeter/trunk/src/components/org/apache/jmeter/sampler/TestAction.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/sampler/TestAction.java?rev=1630230&r1=1630229&r2=1630230&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/sampler/TestAction.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/sampler/TestAction.java Wed Oct  8 20:56:20 2014
@@ -118,7 +118,11 @@ public class TestAction extends Abstract
         }
         try {
             pauseThread = Thread.currentThread();
-            TimeUnit.MILLISECONDS.sleep(milis);
+            if(milis>=0) {
+                TimeUnit.MILLISECONDS.sleep(milis);
+            } else {
+                throw new IllegalArgumentException("Configured sleep is negative:"+milis);
+            }
         } catch (InterruptedException e) {
             // NOOP
         } finally {

Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1630230&r1=1630229&r2=1630230&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml (original)
+++ jmeter/trunk/xdocs/changes.xml Wed Oct  8 20:56:20 2014
@@ -222,6 +222,7 @@ for details on configuring this componen
 <li><bugzilla>56539</bugzilla> - Mail reader sampler: When Number of messages to retrieve is superior to 1, Number of samples should only show 1 not the number of messages retrieved</li>
 <li><bugzilla>56809</bugzilla> - JMSSampler closes InitialContext too early. Contributed by Bradford Hovinen (hovinen at gmail.com)</li>
 <li><bugzilla>56761</bugzilla> - JMeter tries to stop already stopped JMS connection and displays "The connection is closed"</li>
+<li><bugzilla>57068</bugzilla> - No error thrown when negative duration is entered in Test Action</li>
 </ul>
 
 <h3>Controllers</h3>