[GitHub] [superset] junlincc commented on pull request #12609: feat: default timepicker to last week when dataset is changed

[GitBox <gi...@apache.org>]

junlincc commented on pull request #12609:
URL: https://github.com/apache/superset/pull/12609#issuecomment-765880157


   @pkdotson 
   thanks for the PR!
   1. when user change a dataset, control panel reset time range to Last week automatically on pill ✅
   2. but when you click the pill and open popover, notice it's still the time range setting, in this case, last year -> not matching the pill
   
   https://user-images.githubusercontent.com/67837651/105571508-2f04de80-5d05-11eb-92dd-e95c68ed2eb9.mov
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org