[GitHub] [incubator-nuttx] anchao commented on pull request #3871: arch: adjust idle stack offset to reserve space of stack info

[GitBox <gi...@apache.org>]

anchao commented on pull request #3871:
URL: https://github.com/apache/incubator-nuttx/pull/3871#issuecomment-856904536


   Hi @davids5 
   
   > If the user wants a 4096 stack they will not get the value they set. That seam wrong and confusing.
   > 
   > The TLS size should be added the the allocation So that USER+TLS == stack(USER's STACK) + (tls size) (rounded up for alignment)
   
   Idle thread is special, the stack size of idle thread cannot be round up because the most of boards are used to writing the definition of idle thread stack size in the link script, which is fixed, If the TLS or stack info part is increased by mistake, then Will cause unexpected issues,
   
   Therefore, in the idle thread case, we will deduct the tls part from the current idle thread stack, so that although a part of the proc show is missing, it will not affect the operation of the program.
   
   Seriously, Round up or alignment the TLS size for idle thread is meaningless, this is just for the proc show to the user. Of course, if you insist, I will make similar changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org