[GitHub] [iceberg] rymurr commented on a change in pull request #2266: Implement python drop_table

[GitBox <gi...@apache.org>]

rymurr commented on a change in pull request #2266:
URL: https://github.com/apache/iceberg/pull/2266#discussion_r589035582



##########
File path: python/iceberg/api/manifest_file.py
##########
@@ -27,6 +27,7 @@
 
 
 class ManifestFile(object):
+

Review comment:
       nit: unrelated whitespace change

##########
File path: python/tox.ini
##########
@@ -88,7 +88,7 @@ commands =
 #     python -m http.server {posargs}
 
 [flake8]
-ignore = E501,W503
+ignore = E501,W503,C901

Review comment:
       it depends on the python you ran it on. py3.8 changed the parse rules and the most recent linters fix it. #2268 changed the linters to run on py38 so should work fine on master now




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org