[GitHub] [commons-email] garydgregory commented on a diff in pull request #80: [EMAIL-203] Jakarta 2

[GitBox <gi...@apache.org>]

garydgregory commented on code in PR #80:
URL: https://github.com/apache/commons-email/pull/80#discussion_r892940179


##########
src/main/java/org/apache/commons/mail/ByteArrayDataSource.java:
##########
@@ -39,11 +39,11 @@
  * and it is recommended to do so.
  *
  * @since 1.0
- * @deprecated since 1.4, use {@link javax.mail.util.ByteArrayDataSource} instead
+ * @deprecated since 1.4, use {@link jakarta.mail.util.ByteArrayDataSource} instead
  */
 @Deprecated
 public class ByteArrayDataSource implements DataSource
-{
+{ 

Review Comment:
   Reduce the noise in this PR please.



##########
pom.xml:
##########
@@ -256,7 +256,7 @@
         <dependency>
             <groupId>org.slf4j</groupId>
             <artifactId>slf4j-jdk14</artifactId>
-            <version>1.7.7</version>
+            <version>1.7.30</version>

Review Comment:
   Don't do this in this PR, keep changes to what is direclty related, which this... not?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org