You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/14 19:21:38 UTC

[GitHub] [arrow] joosthooz commented on a diff in pull request #14414: ARROW-17991: [Python] [C++] WIP Adding support for IpcWriteOptions to the dataset ipc file writer

joosthooz commented on code in PR #14414:
URL: https://github.com/apache/arrow/pull/14414#discussion_r996067868


##########
python/pyarrow/_dataset.pyx:
##########
@@ -1174,6 +1189,12 @@ cdef class IpcFileFormat(FileFormat):
 
     def equals(self, IpcFileFormat other):
         return True
+    
+    def make_write_options(self, **kwargs):
+        cdef IpcFileWriteOptions opts = \
+            <IpcFileWriteOptions> FileFormat.make_write_options(self)
+        opts.options = IpcWriteOptions(**kwargs)

Review Comment:
   Thanks, fixed!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org