You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:48:52 UTC

[GitHub] [mynewt-core] kasjer commented on pull request #2695: Fix nrf51 clock init

kasjer commented on pull request #2695:
URL: https://github.com/apache/mynewt-core/pull/2695#issuecomment-944302871


   I think code change would be good but...
   For now maybe it fixes something (not clear what) and it breaks build for other nrf51 based BSPs (nordic_pca10028, nordic_pca10028-16k bbc_microbit, bmd200, calliope_mini, nrf51-blenano, nrf51-arduino_101, vbluno51).
   
   To make it look good all affected BSP should be updated.
   Commit message is just too enigmatic.
   It states that if fixes something but it is not clear what was broken.
   Changes are similar to what was applied to NRF52 but at least two things were introduce:
   - clock selection with choice in yml
   - and fix for something in clock setting, it would be good if commit message explained that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org