[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #588: [WIP] Add sequence number for supporting row level delete

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #588: [WIP] Add sequence number for supporting row level delete
URL: https://github.com/apache/incubator-iceberg/pull/588#discussion_r377842072
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/BaseSnapshot.java
 ##########
 @@ -185,6 +211,15 @@ private void cacheChanges() {
     this.cachedDeletes = deletes.build();
   }
 
+  @Override
+  public Long sequenceNumber() {
 
 Review comment:
   I agree with Ryan that old writers should not be allowed to write to tables with sequence numbers. It seems like the right time to bump the format version and include new manifest types and snapshot id inheritance. Then we can safely assign 0 sequence number to all files that were written before we start assigning new ones.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org