You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2023/12/23 16:24:56 UTC
[I] Upgrade to protobuf 3.15 so that we can use `optional` keyword [arrow-datafusion]
andygrove opened a new issue, #8639:
URL: https://github.com/apache/arrow-datafusion/issues/8639
### Is your feature request related to a problem or challenge?
Protobuf 3.15 adds support for optional fields, which could make our code cleaner in some cases.
https://github.com/protocolbuffers/protobuf/releases/tag/v3.15.0
### Describe the solution you'd like
Update docs, scripts, and CI to use the new version.
We need to check that this isn't problematic for downstream crates.
### Describe alternatives you've considered
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Upgrade to protobuf 3.15 so that we can use `optional` keyword [arrow-datafusion]
Posted by "edmondop (via GitHub)" <gi...@apache.org>.
edmondop commented on issue #8639:
URL: https://github.com/apache/arrow-datafusion/issues/8639#issuecomment-1868526494
> IIRC the LTS versions of Ubuntu were still on an older version of protobuf by default
I am not sure I understood, the CI/CD pipelines install a precise version of the protobuf compiler (21.4 if I am not wrong). Your comment suggests there's another part of the story, can you explain?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Upgrade to protobuf 3.15 so that we can use `optional` keyword [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey closed issue #8639: Upgrade to protobuf 3.15 so that we can use `optional` keyword
URL: https://github.com/apache/datafusion/issues/8639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Upgrade to protobuf 3.15 so that we can use `optional` keyword [arrow-datafusion]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #8639:
URL: https://github.com/apache/arrow-datafusion/issues/8639#issuecomment-1868529198
Some users of DataFusion may be on an LTS version of Ubuntu (or some other distro) and therefore not have a newer version of the protobuf-compiler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Upgrade to protobuf 3.15 so that we can use `optional` keyword [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on issue #8639:
URL: https://github.com/apache/datafusion/issues/8639#issuecomment-3292497871
We already use `optional` keyword in proto definition now:
https://github.com/apache/datafusion/blob/8b19ce83da1e89b1bd38626049135a0ca842694c/datafusion/proto/proto/datafusion.proto#L519
And the development environment docs specifically require 3.15 now:
https://github.com/apache/datafusion/blob/8b19ce83da1e89b1bd38626049135a0ca842694c/docs/source/contributor-guide/development_environment.md?plain=1#L65-L70
- See related PR #11006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Upgrade to protobuf 3.15 so that we can use `optional` keyword [arrow-datafusion]
Posted by "edmondop (via GitHub)" <gi...@apache.org>.
edmondop commented on issue #8639:
URL: https://github.com/apache/arrow-datafusion/issues/8639#issuecomment-1868325679
@andygrove I briefly looked into that. It seems that Protobuf have changed their versioning scheme recently if you see the releases https://github.com/protocolbuffers/protobuf/tags
https://protobuf.dev/news/2022-05-06/#versioning
Should we say we need 3.15.X at least?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Upgrade to protobuf 3.15 so that we can use `optional` keyword [arrow-datafusion]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #8639:
URL: https://github.com/apache/arrow-datafusion/issues/8639#issuecomment-1868332302
IIRC the LTS versions of Ubuntu were still on an older version of protobuf by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org