You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/03/06 13:09:18 UTC
[GitHub] [incubator-skywalking] wu-sheng opened a new pull request #2321:
Envoy metric support and a bug fix
wu-sheng opened a new pull request #2321: Envoy metric support and a bug fix
URL: https://github.com/apache/incubator-skywalking/pull/2321
Hi @hanahmily @dio @ZackButcher
By refering Envoy official document, https://www.envoyproxy.io/docs/envoy/latest/configuration/statistics. I am adding the support all Guage type metric from Envoy **MetricsService**.
In default OAL script, I add three metrics
```
// Envoy instance metric
envoy_heap_memory_max_used = from(EnvoyInstanceMetric.value).filter(metricName == "server.memory_heap_size").maxDouble();
envoy_total_connections_used = from(EnvoyInstanceMetric.value).filter(metricName == "server.total_connections").maxDouble();
envoy_parent_connections_used = from(EnvoyInstanceMetric.value).filter(metricName == "server.parent_connections").maxDouble();
```
The metrics are
1. envoy_heap_memory_max_used. Envoy's max heap memory used.
2. envoy_total_connections_used. Envoy's max total connection.
3. envoy_parent_connections_used. Envoy's max parent connection.
Also in this pr, I fixed a bug, the old `EqualMatch` didn't work well.
@TinyAllen We need to add these three metrics in instance level metric template. Look forward the totally new RocketBot UI, and integration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services