[jira] [Commented] (REEF-43) Hard-coded REEF_VERSION is out of date

["Markus Weimer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/REEF-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214743#comment-14214743 ] 

Markus Weimer commented on REEF-43:
-----------------------------------

Thanks for the find!

The idea was to automatically populate that field wit the current version from Maven as well as the GIT hash of it. That way, we could drop that info into the log file to help us debug things.

Obviously, we haven't gotten around to do that yet :-). Maybe now is the time to do that? Otherwise I am fine with removing it altogether, as it only confuses in its current state.

> Hard-coded REEF_VERSION is out of date
> --------------------------------------
>
>                 Key: REEF-43
>                 URL: https://issues.apache.org/jira/browse/REEF-43
>             Project: REEF
>          Issue Type: Bug
>          Components: REEF-Common
>            Reporter: Brian Cho
>            Assignee: Brian Cho
>
> The REEF interface defines a method getVersion(), and a hard-coded variable REEF_VERSION, set to "0.6-SNAPSHOT".
> REEFImplementation eventually read REEF_VERSION, so any calls to this method would return the wrong version.
> The proposed fix is to remove the API altogether. No calls are made to getVersion() from within REEF; as no one has complained so far I think it's safe to say no calls it outside of REEF.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)