You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "W-Mai (via GitHub)" <gi...@apache.org> on 2024/01/26 20:18:59 UTC
[PR] CMake: add `nuttx_tweak_kconfig` and `nuttx_sethost` for cmake build system [nuttx]
W-Mai opened a new pull request, #11608:
URL: https://github.com/apache/nuttx/pull/11608
## Summary
Add the `nuttx_tweak_kconfig` function and the `nuttx_sethost` function to the current Nuttx `CMake` build system to ensure that the code can be compiled correctly on different platforms and architectures.
## Impact
N/A
## Testing
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CMake: add `nuttx_tweak_kconfig` and `nuttx_sethost` for cmake build system [nuttx]
Posted by "xuxin930 (via GitHub)" <gi...@apache.org>.
xuxin930 commented on PR #11608:
URL: https://github.com/apache/nuttx/pull/11608#issuecomment-2008993205
the reason why this CI failed is because once the CMake Toolchain is solidified, it cannot be changed.
refer: https://github.com/apache/nuttx/issues/11452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CMake: add `nuttx_tweak_kconfig` and `nuttx_sethost` for cmake build system [nuttx]
Posted by "W-Mai (via GitHub)" <gi...@apache.org>.
W-Mai commented on PR #11608:
URL: https://github.com/apache/nuttx/pull/11608#issuecomment-2008604786
@anchao cc @xuxin930
At present, it is not so easy to develop nuttx in native windows, and now it is not easy to solve the problem of cmake environment variables that obtain information about the processor architecture, so I think we can
1. default windows to x86 architecture,
2. or let windows users manually specify the processor architecture,
3. or let windows users develop using posix-supporting environments such as wsl or docker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CMake: add `nuttx_tweak_kconfig` and `nuttx_sethost` for cmake build system [nuttx]
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on PR #11608:
URL: https://github.com/apache/nuttx/pull/11608#issuecomment-1913055123
tweak config is not a violent change of a certain kconfig variable, which needs to parse all kconfig topologies, including dependencies and selection rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CMake: add `nuttx_tweak_kconfig` and `nuttx_sethost` for cmake build system [nuttx]
Posted by "W-Mai (via GitHub)" <gi...@apache.org>.
W-Mai commented on PR #11608:
URL: https://github.com/apache/nuttx/pull/11608#issuecomment-1913072563
> tweak config is not a violent change of a certain kconfig variable, which needs to parse all kconfig topologies, including dependencies and selection rules.
Oh, sure, I realized, so that is to say, it is better to execute COMMAND to call `kconfig-tweak` to operate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CMake: add `nuttx_tweak_kconfig` and `nuttx_sethost` for cmake build system [nuttx]
Posted by "W-Mai (via GitHub)" <gi...@apache.org>.
W-Mai commented on PR #11608:
URL: https://github.com/apache/nuttx/pull/11608#issuecomment-1913562951
> @W-Mai could you please fix this warning: The head ref may contain hidden characters: "\u{1F617}"
Don't worry, it's a branch name warning, it doesn't matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CMake: add `nuttx_tweak_kconfig` and `nuttx_sethost` for cmake build system [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #11608:
URL: https://github.com/apache/nuttx/pull/11608#issuecomment-1913329751
@W-Mai could you please fix this warning: The head ref may contain hidden characters: "\u{1F617}"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CMake: add `nuttx_tweak_kconfig` and `nuttx_sethost` for cmake build system [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #11608:
URL: https://github.com/apache/nuttx/pull/11608#issuecomment-1913738832
Please check the CI, it still failing. I tried to re-run the failing jobs, but now it is failing in other places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CMake: add `nuttx_tweak_kconfig` and `nuttx_sethost` for cmake build system [nuttx]
Posted by "W-Mai (via GitHub)" <gi...@apache.org>.
W-Mai commented on PR #11608:
URL: https://github.com/apache/nuttx/pull/11608#issuecomment-1913993911
> Please check the CI, it still failing. I tried to re-run the failing jobs, but now it is failing in other places
I have encountered some deeper problems, which may take some time to deal with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CMake: add `nuttx_tweak_kconfig` and `nuttx_sethost` for cmake build system [nuttx]
Posted by "W-Mai (via GitHub)" <gi...@apache.org>.
W-Mai closed pull request #11608: CMake: add `nuttx_tweak_kconfig` and `nuttx_sethost` for cmake build system
URL: https://github.com/apache/nuttx/pull/11608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CMake: add `nuttx_tweak_kconfig` and `nuttx_sethost` for cmake build system [nuttx]
Posted by "xuxin930 (via GitHub)" <gi...@apache.org>.
xuxin930 commented on PR #11608:
URL: https://github.com/apache/nuttx/pull/11608#issuecomment-2009069770
> tweak config is not a violent change of a certain kconfig variable, which needs to parse all kconfig topologies, including dependencies and selection rules.
hi @anchao I tested the refresh we are using now,
kconfig-tweak does not change dependencies, and execute `select`.
kconfiglib's `setconfig` will help us accomplish this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org