[GitHub] [trafficserver] traeak commented on a change in pull request #8666: slice and cache_range_requests: allow header override

[GitBox <gi...@apache.org>]

traeak commented on a change in pull request #8666:
URL: https://github.com/apache/trafficserver/pull/8666#discussion_r807328170



##########
File path: plugins/cache_range_requests/cache_range_requests.cc
##########
@@ -111,24 +112,29 @@ create_pluginconfig(int argc, char *const argv[])
   --argv;
 
   for (;;) {
-    int const opt = getopt_long(argc, argv, "", longopts, nullptr);
+    int const opt = getopt_long(argc, argv, "i:", longopts, nullptr);
     if (-1 == opt) {
       break;
     }
 
     switch (opt) {
-    case 'p': {
-      DEBUG_LOG("Plugin modifies parent selection key");
-      pc->ps_mode = PS_CACHEKEY_URL;
-    } break;
     case 'c': {
-      DEBUG_LOG("Plugin considers the '%.*s' header", (int)X_IMS_HEADER.size(), X_IMS_HEADER.data());
+      DEBUG_LOG("Plugin considers the CRR ims header");

Review comment:
       The other 2 messages in the same function should cover it (based on override being used or not):
   
   DEBUG_LOG("Plugin uses custom CRR ims header: %s", optarg);
   DEBUG_LOG("Plugin uses default ims header: %s", pc->ims_header.c_str())




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org