You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gautam Borad <gb...@gmail.com> on 2016/01/08 12:01:50 UTC
Review Request 41975: AMBARI-14562 : Ranger - If configured audit
store is 'solr', then audit_store value should be 'solr'
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41975/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: AMBARI-14562
https://issues.apache.org/jira/browse/AMBARI-14562
Repository: ambari
Description
-------
Patch contains changes in stacks for Ranger to update value of 'audit_store' property based on Audits Enabled in smart configs section (Solr / DB / HDFS).
Patch also contains stack advisor recommendations to recommend the changes if Audit to DB, Solr is enabled / disabled.
Diffs
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 119da1a
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml e9eecde
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 02c7482
ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 22fcb1b
Diff: https://reviews.apache.org/r/41975/diff/
Testing
-------
Tested below given test cases :
1) Checked value / recommendation for 'audit_store' if only Audit to DB is enabled ::
audit_store = db
2) Checked value / recommendation for 'audit_store' if only Audit to Solr is enabled
audit_store = solr
3) Checked value / recommendation for 'audit_store' if Audit to DB and Audit to Solr both are enabled
audit_store = solr
4) Checked value / recommendation for 'audit_store' if only Audit to HDFS is enabled
audit_store = solr
5) Verified Ambari upgrade scenario
----------------------------------------------------------------------
Ran 271 tests in 6.910s
OK
----------------------------------------------------------------------
Total run:893
Total errors:0
Total failures:0
OK
Thanks,
Gautam Borad
Re: Review Request 41975: AMBARI-14562 : Ranger - If configured audit
store is 'solr', then audit_store value should be 'solr'
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41975/#review117239
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Feb. 1, 2016, 12:24 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41975/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 12:24 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14562
> https://issues.apache.org/jira/browse/AMBARI-14562
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains changes in stacks for Ranger to update value of 'audit_store' property based on Audits Enabled in smart configs section (Solr / DB / HDFS).
>
> Patch also contains stack advisor recommendations to recommend the changes if Audit to DB, Solr is enabled / disabled.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 119da1a
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml e9eecde
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 0544f5a
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 362a7cd
>
> Diff: https://reviews.apache.org/r/41975/diff/
>
>
> Testing
> -------
>
> Tested below given test cases :
>
> 1) Checked value / recommendation for 'audit_store' if only Audit to DB is enabled ::
> audit_store = db
> 2) Checked value / recommendation for 'audit_store' if only Audit to Solr is enabled
> audit_store = solr
> 3) Checked value / recommendation for 'audit_store' if Audit to DB and Audit to Solr both are enabled
> audit_store = solr
> 4) Checked value / recommendation for 'audit_store' if only Audit to HDFS is enabled
> audit_store = solr
> 5) Verified Ambari upgrade scenario
>
> ----------------------------------------------------------------------
> Ran 271 tests in 6.910s
> OK
> ----------------------------------------------------------------------
> Total run:893
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 41975: AMBARI-14562 : Ranger - If configured audit
store is 'solr', then audit_store value should be 'solr'
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41975/
-----------------------------------------------------------
(Updated Feb. 1, 2016, 12:24 p.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Formatted xml file for consistent indentation and removed condition :
if audit_solr_flag == 'true':
ranger_audit_source_type = 'solr'
Bugs: AMBARI-14562
https://issues.apache.org/jira/browse/AMBARI-14562
Repository: ambari
Description
-------
Patch contains changes in stacks for Ranger to update value of 'audit_store' property based on Audits Enabled in smart configs section (Solr / DB / HDFS).
Patch also contains stack advisor recommendations to recommend the changes if Audit to DB, Solr is enabled / disabled.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 119da1a
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml e9eecde
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 0544f5a
ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 362a7cd
Diff: https://reviews.apache.org/r/41975/diff/
Testing
-------
Tested below given test cases :
1) Checked value / recommendation for 'audit_store' if only Audit to DB is enabled ::
audit_store = db
2) Checked value / recommendation for 'audit_store' if only Audit to Solr is enabled
audit_store = solr
3) Checked value / recommendation for 'audit_store' if Audit to DB and Audit to Solr both are enabled
audit_store = solr
4) Checked value / recommendation for 'audit_store' if only Audit to HDFS is enabled
audit_store = solr
5) Verified Ambari upgrade scenario
----------------------------------------------------------------------
Ran 271 tests in 6.910s
OK
----------------------------------------------------------------------
Total run:893
Total errors:0
Total failures:0
OK
Thanks,
Gautam Borad