You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by bh...@apache.org on 2020/08/18 23:55:23 UTC

[beam] branch master updated: [BEAM-10752] add use_deprecated_read experiment for testSimpleInsert, testSimpleInsertFlat (#12621)

This is an automated email from the ASF dual-hosted git repository.

bhulette pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 18a8edd  [BEAM-10752] add use_deprecated_read experiment for testSimpleInsert, testSimpleInsertFlat (#12621)
18a8edd is described below

commit 18a8eddefa2403d6cfdd96e1beee1a26c5e5e87a
Author: Brian Hulette <bh...@google.com>
AuthorDate: Tue Aug 18 16:55:02 2020 -0700

    [BEAM-10752] add use_deprecated_read experiment for testSimpleInsert, testSimpleInsertFlat (#12621)
    
    * add use_deprecated_read experiment for testSimpleInsert, testSimpleInsertFlat
    
    * Fix JIRA id
---
 .../apache/beam/sdk/extensions/sql/PubsubToBigqueryIT.java  | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/PubsubToBigqueryIT.java b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/PubsubToBigqueryIT.java
index 24eba2e..cb394ef 100644
--- a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/PubsubToBigqueryIT.java
+++ b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/PubsubToBigqueryIT.java
@@ -31,6 +31,7 @@ import org.apache.beam.sdk.extensions.sql.meta.provider.pubsub.PubsubJsonTablePr
 import org.apache.beam.sdk.io.gcp.bigquery.TestBigQuery;
 import org.apache.beam.sdk.io.gcp.pubsub.PubsubMessage;
 import org.apache.beam.sdk.io.gcp.pubsub.TestPubsub;
+import org.apache.beam.sdk.options.ExperimentalOptions;
 import org.apache.beam.sdk.schemas.Schema;
 import org.apache.beam.sdk.testing.TestPipeline;
 import org.apache.beam.sdk.values.Row;
@@ -55,6 +56,12 @@ public class PubsubToBigqueryIT implements Serializable {
 
   @Test
   public void testSimpleInsert() throws Exception {
+    // TODO(BEAM-10752): Reading from pubsub shouldn't require deprecated read
+    pipeline
+        .getOptions()
+        .as(ExperimentalOptions.class)
+        .setExperiments(ImmutableList.of("use_deprecated_read"));
+
     BeamSqlEnv sqlEnv =
         BeamSqlEnv.inMemory(new PubsubJsonTableProvider(), new BigQueryTableProvider());
 
@@ -113,6 +120,12 @@ public class PubsubToBigqueryIT implements Serializable {
 
   @Test
   public void testSimpleInsertFlat() throws Exception {
+    // TODO(BEAM-10752): Reading from pubsub shouldn't require deprecated read
+    pipeline
+        .getOptions()
+        .as(ExperimentalOptions.class)
+        .setExperiments(ImmutableList.of("use_deprecated_read"));
+
     BeamSqlEnv sqlEnv =
         BeamSqlEnv.inMemory(new PubsubJsonTableProvider(), new BigQueryTableProvider());