You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by "mlbiscoc (via GitHub)" <gi...@apache.org> on 2024/12/13 15:07:14 UTC

[PR] SOLR-17548: Switch all public Java APIs from File to Path [solr]

mlbiscoc opened a new pull request, #2907:
URL: https://github.com/apache/solr/pull/2907

https://issues.apache.org/jira/browse/SOLR-17548

# Description

Move from `File` to the more modern `java.nio.file.Path`

# Solution

Tried to find all of the public constructors/methods where `File` is being used or returned as a type and do it's conversion to `Path` instead. If the conversion was simple, also changed the `File` methods being used to its equivalent `Path` methods to stop using the `toFile()` call.

There were some places where it required a much larger rework which felt at of scope of this already large number of changes. For those I placed a `// TODO SOLR-8282 move to PATH`

# Tests

Modified most uses of `File` to `Path` and many of the changes revolve around me removing the `toPath()`.

# Checklist

Please review the following and check all that apply:

- [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

Re: [PR] SOLR-17548: Switch all public Java APIs from File to Path [solr]

Posted by "dsmiley (via GitHub)" <gi...@apache.org>.

dsmiley commented on code in PR #2907:
URL: https://github.com/apache/solr/pull/2907#discussion_r1887546435


##########
solr/core/src/java/org/apache/solr/update/UpdateLog.java:
##########


Review Comment:
   nice!



##########
solr/core/src/java/org/apache/solr/util/FileUtils.java:
##########
@@ -55,16 +54,16 @@ public static void copyFile(File src, File destination) throws IOException {
    * @param fullFile the File to be synced to disk
    * @throws IOException if the file could not be synced
    */
-  public static void sync(File fullFile) throws IOException {
-    if (fullFile == null || !fullFile.exists())
+  public static void sync(Path fullFile) throws IOException {

Review Comment:
   now remove the method



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org